Skip to content

feat(v7): get_evaluation_result - #239

Merged
khvn26 merged 45 commits into
mainfrom
feat/v7-get-evaluation-result
Aug 18, 2025
Merged

feat(v7): get_evaluation_result#239
khvn26 merged 45 commits into
mainfrom
feat/v7-get-evaluation-result

Conversation

@khvn26

@khvn26khvn26 commented Aug 12, 2025

Copy link
Copy Markdown
Member

Contributes to #234.

For now, the PR maintains full backwards compatibility. Hopefully, we'll be able to release V7 without the old interfaces and models altogether. This should allow us do ditch the Pydantic dependency. Worst case scenario, get_environment_feature_state[s]/get_identity_feature_state[s] will stay but produce a DeprecationWarning.

I've started some threads to add my own notes on the code, everybody's welcome to add comments there.

@khvn26
khvn26force-pushed the feat/v7-get-evaluation-result branch 2 times, most recently from ca412c7 to fdd18f8CompareAugust 12, 2025 11:14
@khvn26
khvn26force-pushed the feat/v7-get-evaluation-result branch from fdd18f8 to 4364c6eCompareAugust 12, 2025 11:15
@github-actions

github-actionsBot commented Aug 12, 2025

Copy link
Copy Markdown

FileCoverageMissing
All files100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against d1f6414

Comment threadflag_engine/context/mappers.py
Comment threadflag_engine/context/mappers.py Outdated
Comment threadflag_engine/context/mappers.py Outdated
@khvn26
khvn26 requested review from a team and gagantrivedi and removed request for a teamAugust 12, 2025 13:31
Comment threadflag_engine/segments/evaluator.py
Comment threadflag_engine/context/mappers.py
@khvn26
khvn26force-pushed the feat/v7-get-evaluation-result branch from 129108b to fb31c9cCompareAugust 15, 2025 19:47
Comment threadflag_engine/segments/evaluator.py

@Zaimwa9Zaimwa9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One NIT on my side, otherwise looks like we are reaching the end. Updated mappers in python-client accordingly

Comment threadflag_engine/segments/evaluator.py Outdated
Zaimwa9
Zaimwa9 previously approved these changes Aug 18, 2025

@Zaimwa9Zaimwa9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@khvn26
khvn26 enabled auto-merge (squash) August 18, 2025 16:05
@khvn26
khvn26 removed the request for review from gagantrivediAugust 18, 2025 16:06
@khvn26
khvn26 disabled auto-merge August 18, 2025 16:06
@khvn26
khvn26 merged commit b1e4447 into mainAug 18, 2025
6 checks passed
@khvn26
khvn26 deleted the feat/v7-get-evaluation-result branch August 18, 2025 16:07

@matthewelwellmatthewelwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per request from @khvn26 I have retrospectively reviewed the code. While I think there are sections which are quite complex, I can definitely see some of the benefits starting to appear. Looks good!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@khvn26@Zaimwa9@emyller@matthewelwell