Uh oh!
There was an error while loading. Please reload this page.
feat(v7): get_evaluation_result - #239
Conversation
ca412c7 to
fdd18f8Comparefdd18f8 to
4364c6eCompare
Minimum allowed coverage is Generated by 🐒 cobertura-action against d1f6414 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Evandro Myller <22429+emyller@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
129108b to
fb31c9cCompareUh oh!
There was an error while loading. Please reload this page.
Zaimwa9
left a comment
There was a problem hiding this comment.
One NIT on my side, otherwise looks like we are reaching the end. Updated mappers in python-client accordingly
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
matthewelwell
left a comment
There was a problem hiding this comment.
As per request from @khvn26 I have retrospectively reviewed the code. While I think there are sections which are quite complex, I can definitely see some of the benefits starting to appear. Looks good!
Contributes to #234.
For now, the PR maintains full backwards compatibility. Hopefully, we'll be able to release V7 without the old interfaces and models altogether. This should allow us do ditch the Pydantic dependency. Worst case scenario,
get_environment_feature_state[s]/get_identity_feature_state[s]will stay but produce aDeprecationWarning.I've started some threads to add my own notes on the code, everybody's welcome to add comments there.