Skip to content

fix(Tests): Fix overrides priority - #260

Closed
emyller wants to merge 1 commit into
mainfrom
fix/evil-walrus
Closed

fix(Tests): Fix overrides priority#260
emyller wants to merge 1 commit into
mainfrom
fix/evil-walrus

Conversation

@emyller

@emylleremyller commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

Fixes "priority" rendering to a bool in engine test data (noticed here).

Note

The ultimate goal is to make engine-test-data reliable as direct source of test cases (as of Flagsmith/engine-test-data#12). This pull request exists for awareness.

@github-actions

Copy link
Copy Markdown

FileCoverageMissing
All files100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against 86437ab

@codspeed-hq

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #260 will not alter performance

Comparing fix/evil-walrus (86437ab) with main (b4a47d7)

Summary

✅ 1 untouched

@emyller

Copy link
Copy Markdown
ContributorAuthor

@khvn26 All tests pass, in despite of the significant change of meaning in "priority". Should we investigate?

@emylleremyller self-assigned this Sep 18, 2025
@emyller

Copy link
Copy Markdown
ContributorAuthor

To be superseded by Flagsmith/engine-test-data#12.

@emylleremyller closed this Oct 1, 2025
@emyller
emyller deleted the fix/evil-walrus branch October 1, 2025 15:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@emyller