Skip to content

fix: handle environment documentation pagination - #205

Merged
Zaimwa9 merged 9 commits into
mainfrom
fix/handle-environment-documentation-pagination
Oct 15, 2025
Merged

fix: handle environment documentation pagination#205
Zaimwa9 merged 9 commits into
mainfrom
fix/handle-environment-documentation-pagination

Conversation

@Zaimwa9

@Zaimwa9Zaimwa9 commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

closes#204

Changes

  • Iterates over api/v1/environment-document until all pages have been consumed
  • consolidate pages into a single environment document
  • log a warning if total time exceeded polling interval

How did you test this code?

  • added test
// Using staging-api with lower body_size constraints with a dummy app logging
nextMatch /api/v1/environment-document/?page_id=identity_override:60074:3035e1fa-320a-48ec-822c-5ed30f839dfb
nextMatch /api/v1/environment-document/?page_id=identity_override:60074:331a5b10-6cd6-41df-95f9-4049a1c5dadf
nextMatch /api/v1/environment-document/?page_id=identity_override:60074:35aa8f9a-e82c-429c-90ea-26f0e8fa6da1
nextMatch /api/v1/environment-document/?page_id=identity_override:60074:3861ff9a-e95e-4304-9f95-658f3ccf4710
nextMatch /api/v1/environment-document/?page_id=identity_override:60074:3b5a58a1-e678-4c37-9e07-22303ce2e4a8
documents-pages 21
Flags numbers: 2

@Zaimwa9
Zaimwa9 requested a review from a team as a code ownerOctober 3, 2025 10:59
@Zaimwa9
Zaimwa9 requested review from gagantrivedi and removed request for a teamOctober 3, 2025 10:59
Comment threadtests/engine/engine-tests/engine-test-data
@Zaimwa9
Zaimwa9 requested a review from khvn26October 3, 2025 13:50
Comment threadtests/sdk/flagsmith.test.ts Outdated
@Zaimwa9
Zaimwa9 requested a review from khvn26October 8, 2025 08:47
…nto fix/handle-environment-documentation-pagination

@gagantrivedigagantrivedi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some questions

Comment threadsdk/index.ts
Comment threadsdk/index.ts
Comment threadsdk/index.ts Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement pagination support for local evaluation

3 participants

@Zaimwa9@khvn26@gagantrivedi