Skip to content

feat!: Engine V7 compatibility - #150

Merged
khvn26 merged 13 commits into
mainfrom
feat/engine-v7-compatibility
Sep 1, 2025
Merged

feat!: Engine V7 compatibility#150
khvn26 merged 13 commits into
mainfrom
feat/engine-v7-compatibility

Conversation

@khvn26

@khvn26khvn26 commented Aug 26, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Closes#144, #145.

In this PR, we:

  • Drop Python 3.8 support.
  • Drop the Pydantic dependency.
  • Stop respecting hide_disabled_flags in Local evaluation mode.
  • Eliminate all usage of Engine v6's Pydantic models and fully switch to EvaluationContext and EvaluationResult usage.
  • Introduce the new OfflineHandler signature, add a new evaluation context-based LocalOfflineHandler, and preserve an environment document-based one.
  • Map identity overrides from the environment document to segments in the engine evaluation context.

This makes the Python SDK fully compatible with next major version of the engine and fully enables Context values in local evaluation mode.

@khvn26
khvn26 requested a review from a team as a code ownerAugust 26, 2025 15:17
@khvn26
khvn26 requested review from Zaimwa9 and removed request for a teamAugust 26, 2025 15:17
khvn26
khvn26 commented Aug 26, 2025
View reviewed changes
Comment threadpyproject.toml Outdated
@khvn26khvn26 mentioned this pull request Aug 27, 2025
Closed
emyller
emyller previously approved these changes Aug 28, 2025
View reviewed changes

@emylleremyller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with non-blocking comments.

Comment threadflagsmith/flagsmith.py Outdated
Comment threadflagsmith/flagsmith.py Outdated
Comment threadflagsmith/flagsmith.py Outdated
Comment threadflagsmith/flagsmith.py Outdated
Comment threadflagsmith/mappers.py Outdated
Comment threadflagsmith/offline_handlers.py Outdated
Comment threadflagsmith/offline_handlers.py Outdated
Comment threadflagsmith/offline_handlers.py
Comment threadtests/test_flagsmith.py Outdated
Comment threadflagsmith/mappers.py
@khvn26
khvn26 requested a review from emyllerAugust 29, 2025 18:14
emyller
emyller previously approved these changes Aug 29, 2025
View reviewed changes

@emylleremyller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking every nit!

@khvn26
khvn26 merged commit 5ecb078 into mainSep 1, 2025
7 checks passed
@khvn26
khvn26 deleted the feat/engine-v7-compatibility branch September 1, 2025 16:34
@flagsmithdevflagsmithdev mentioned this pull request Aug 22, 2025
Merged
@Zaimwa9Zaimwa9 mentioned this pull request Dec 18, 2025
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emylleremylleremyller approved these changes
@Zaimwa9Zaimwa9Awaiting requested review from Zaimwa9Zaimwa9 is a code owner automatically assigned from Flagsmith/flagsmith-back-end

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Engine V7 compatibility

2 participants

@khvn26@emyller