Uh oh!
There was an error while loading. Please reload this page.
Ensure CI runs on the correct version of python and fix typing issues - #33
Merged
Conversation
xvaierforce-pushed
the
xavier/fix-old-python-linting
branch
from
May 22, 2026 19:13
94bab7a to
2cb9310Comparexvaierforce-pushed
the
xavier/fix-old-python-linting
branch
from
May 22, 2026 19:14
2cb9310 to
f4243c4Compareaviau
reviewed
May 22, 2026
Uh oh!
There was an error while loading. Please reload this page.
aviau
approved these changes
May 22, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
python-versionmatrix intests.ymlwasn't actually pinning the Python uv used, so every matrix entry was running tests on whatever interpreter uv picked (typically the newest available).This let a Python-3.9 runtime failure (
TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'from PEP 604 unions inmodels.py/api_client.py) pass CI despite "3.9" being green in CI.