Skip to content

fix: preserve trusted gh authentication for GitHub adapter - #21

Merged
sfloess merged 3 commits into
mainfrom
fix/github-credential-boundary
Sep 4, 2026
Merged

fix: preserve trusted gh authentication for GitHub adapter#21
sfloess merged 3 commits into
mainfrom
fix/github-credential-boundary

Conversation

@sfloess

Copy link
Copy Markdown
Member

Summary

  • preserve GH_TOKEN/GITHUB_TOKEN for the trusted gh subprocess
  • keep credentials outside agent state and worker results
  • add regression coverage for CI authentication semantics
  • document the GitHub dogfood acceptance boundary

Why

The previous adapter explicitly removed GH_TOKEN and GITHUB_TOKEN before invoking gh. That prevents the normal GitHub Actions authentication path from working. Credentials should remain outside worker state, but the trusted publication boundary must still be able to consume credentials supplied by its parent environment.

Tests mock gh; no real credentials are required.

@sonarqubecloud

Copy link
Copy Markdown

@sfloess
sfloess merged commit 791ec99 into mainSep 4, 2026
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sfloess