Kotlin style guide discussion

[tomholub]

Here I will leave comments about Kotlin style patterns I notice, and my proposals on which ones seem most readable. Later we will discuss and compromise on something we can both live with :)

So far I noticed:

1. I prefer to avoid Multiline ternary operators:

// Weird
return if (condition) {
 "XXX"
} else {
 "Yyy"
}

// Good
return if (condition) "XXX" else "Yyy"

2. empty when else should be on one line

when (cond) {
 "X" -> functionality ()
 else -> {}
}

[tomholub]

I'm not sure I about the let syntax, I feel an if would be more obvious:

// looks ok but unusual
value?.let {
 something()
}

// Standard
if (value != null) {
 something()
}

The first version is a bit shorter but I would say a bit less obvious.

[DenBond7]

@tomholub

I'm not sure I about the let syntax,

That syntax helps to make the code shorter:

val order: Order? = findOrder()
if (order != null){
 dun(order.customer)
}

or

findOrder()?.let { dun(it.customer) }

But I think will be better to use it only when the code after { takes one line

[tomholub]

Ah, I see the difference now. That's not bad.

[tomholub]

Probably the most important, we should stop using when for asynchronous code, and use Kotlin async routines instead.

// Cannot stand this :)

 when (responseWrapper.requestCode) {
 R.id.req_id_get_version -> {
 val testNodeResult = responseWrapper.result as VersionResult?
 resultText = testNodeResult!!.toString() + "\n\n"
 addResultLine("version", responseWrapper)
 }

 R.id.req_id_encrypt_msg -> {
 val encryptMsgResult = responseWrapper.result as EncryptedMsgResult?
 addResultLine("encrypt-msg", responseWrapper)
 encryptedMsg = encryptMsgResult!!.encryptedMsg
 requestsManager!!.decryptMsg(R.id.req_id_decrypt_msg_ecc, encryptedMsg!!, TestData.eccPrvKeyInfo())
 }
 }