Skip to content

issue #1223 a port of Mime.processDecoded() - #1267

Merged
DenBond7 merged 6 commits into
masterfrom
ip-1223
May 31, 2021
Merged

issue #1223 a port of Mime.processDecoded()#1267
DenBond7 merged 6 commits into
masterfrom
ip-1223

Conversation

@IvanPizhenko

@IvanPizhenkoIvanPizhenko commented May 31, 2021

Copy link
Copy Markdown
Contributor

This PR introduces port of the function Mime.processDecoded() from Typescript to Kotlin.

close#1223 // if this PR closes an issue

Tests(delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@tomholub
tomholub removed their request for review May 31, 2021 07:48
tomholub
tomholub reviewed May 31, 2021
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me overall (didn't dig into details) 👍

Comment thread...t/src/main/java/com/flowcrypt/email/api/retrofit/response/model/node/EncryptedAttMsgBlock.kt
@DenBond7

DenBond7 commented May 31, 2021

Copy link
Copy Markdown
Collaborator

@IvanPizhenko I had to add some changes to fix the JUnit tests that relate to Android. Please look at them.

@DenBond7
Merge branch 'master' into ip-1223
5c38d0b
# Conflicts:
#	FlowCrypt/src/main/java/com/flowcrypt/email/api/retrofit/response/model/node/GenericMsgBlock.kt
#	FlowCrypt/src/main/java/com/flowcrypt/email/api/retrofit/response/model/node/MsgBlockFactory.kt
DenBond7
DenBond7 reviewed May 31, 2021
View reviewed changes
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/api/retrofit/response/model/node/MsgBlock.kt Outdated
DenBond7
DenBond7 requested changes May 31, 2021
View reviewed changes

@DenBond7DenBond7 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the comments

Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/extensions/javax/mail/PartExt.kt Outdated
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt Outdated
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/api/retrofit/response/model/node/MsgBlock.kt Outdated
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt Outdated
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt Outdated
Comment threadFlowCrypt/src/test/java/com/flowcrypt/email/security/pgp/PgpMsgTest.kt Outdated
@IvanPizhenko

IvanPizhenko commented May 31, 2021

Copy link
Copy Markdown
ContributorAuthor

@DenBond7 I've made some fixes, please recheck it

@DenBond7
DenBond7 merged commit 8266be3 into masterMay 31, 2021
@DenBond7
DenBond7 deleted the ip-1223 branch May 31, 2021 17:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomholubtomholubtomholub left review comments
@DenBond7DenBond7DenBond7 approved these changes
@seisvelasseisvelasAwaiting requested review from seisvelas

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

a port of Mime.processDecoded (to MsgBlocks)

3 participants

@IvanPizhenko@DenBond7@tomholub