Uh oh!
There was an error while loading. Please reload this page.
issue #1378 WKD client timeout test - #1379
Merged
Merged
Conversation
DenBond7
reviewed
Aug 2, 2021
| } | ||
| @Test | ||
| fun requestTimeoutTest() { |
Collaborator
There was a problem hiding this comment.
unfortunately, it looks too complicated. Please look at com.flowcrypt.email.rules.FlowCryptMockWebServerRule and an examle of usage
ContributorAuthor
There was a problem hiding this comment.
FlowCryptMockWebServerRule is not available here since this is not "Android Test". However I've looked at it and it gives me idea to use okhttp MockWebServer.
Collaborator
There was a problem hiding this comment.
I meant that it would be better to use a mock web server instead of sockets. It will be clearer.
IvanPizhenkoforce-pushed
the
ip-1378-timeout-test
branch
from
August 3, 2021 08:19
eee94a4 to
d1866b7CompareIvanPizhenko
commented
Aug 3, 2021
ContributorAuthor
@DenBond7 Reworked it, please have a look again. |
DenBond7
reviewed
Aug 3, 2021
Uh oh!
There was an error while loading. Please reload this page.
DenBond7
approved these changes
Aug 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds timeout test for the WKD client and introduces few small fixes to the WKD client itself
close#1378
related issue #1317
Tests(delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):