Uh oh!
There was an error while loading. Please reload this page.
Issue 1682 preview atts for enterprise - #1697
Merged
Merged
Conversation
DenBond7force-pushed
the
issue_1682_preview_atts
branch
from
February 23, 2022 15:02
fe20be6 to
97c34b4CompareDenBond7force-pushed
the
issue_1682_preview_atts
branch
from
February 23, 2022 17:59
97c34b4 to
8c37646Compare…ule.RESTRICT_ANDROID_ATTACHMENT_HANDLING.| #1682
DenBond7force-pushed
the
issue_1682_preview_atts
branch
from
March 2, 2022 16:13
ada2b96 to
d042b58CompareDenBond7force-pushed
the
issue_1682_preview_atts
branch
2 times, most recently
from
March 3, 2022 14:47
3faf7f3 to
57aff14CompareDenBond7force-pushed
the
issue_1682_preview_atts
branch
from
March 3, 2022 15:45
57aff14 to
5d6ac83CompareDenBond7
marked this pull request as ready for review
March 4, 2022 16:25
tomholub
approved these changes
Mar 7, 2022
Comment on lines
+77
to
+81
| val email = | ||
| attachmentInfo.email ?: return@withContext Result.success(byteArrayOf()) | ||
| val account = getAccountEntityWithDecryptedInfoSuspend( | ||
| roomDatabase.accountDao().getAccount(email) | ||
| ) ?: return@withContext Result.success(byteArrayOf()) |
Collaborator
There was a problem hiding this comment.
Shouldn't missing email cause an error to be thrown?
CollaboratorAuthor
There was a problem hiding this comment.
Agree. I will post a new issue for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added a custom logic for enterprise users to manipulate attachments (view, download)
close#1682
Tests(delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):