Skip to content

Refactored code.| #1704 - #1705

Merged
tomholub merged 1 commit into
masterfrom
issue_1704_improve_DownloadAttachmentViewModel
Mar 7, 2022
Merged

Refactored code.| #1704#1705
tomholub merged 1 commit into
masterfrom
issue_1704_improve_DownloadAttachmentViewModel

Conversation

@DenBond7

@DenBond7DenBond7 commented Mar 7, 2022•
edited by tomholub
Loading

Copy link
Copy Markdown
Collaborator

This PR refactored code.

close#1704

Tests(delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7
DenBond7 marked this pull request as ready for review March 7, 2022 16:48
@DenBond7
DenBond7 requested a review from tomholubMarch 7, 2022 16:48
@tomholub
tomholub merged commit caa7285 into masterMar 7, 2022
@tomholub
tomholub deleted the issue_1704_improve_DownloadAttachmentViewModel branch March 7, 2022 16:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomholubtomholubtomholub approved these changes
@IvanPizhenkoIvanPizhenkoAwaiting requested review from IvanPizhenko

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve DownloadAttachmentViewModel

2 participants

@DenBond7@tomholub