Skip to content

Issue 1193 navigation components - #1712

Merged
DenBond7 merged 71 commits into
masterfrom
issue_1193_navigation_components
Apr 17, 2022
Merged

Issue 1193 navigation components#1712
DenBond7 merged 71 commits into
masterfrom
issue_1193_navigation_components

Conversation

@DenBond7

@DenBond7DenBond7 commented Mar 11, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR did the migration to Navigation components over the whole app and other important architecture changes

close#1193
close#1274
close#1709
close#1192

Tests(delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7
DenBond7force-pushed the issue_1193_navigation_components branch from cb9ac46 to df29740CompareMarch 18, 2022 09:56
@DenBond7
DenBond7force-pushed the issue_1193_navigation_components branch 2 times, most recently from 5c23bc8 to d92f3b0CompareMarch 21, 2022 17:47
@DenBond7
DenBond7force-pushed the issue_1193_navigation_components branch from d92f3b0 to 27381c7CompareMarch 21, 2022 18:11
@DenBond7
DenBond7force-pushed the issue_1193_navigation_components branch from 6f7c380 to c96bd0eCompareMarch 22, 2022 08:51
@DenBond7
DenBond7force-pushed the issue_1193_navigation_components branch from 214d00a to 4145576CompareMarch 23, 2022 13:22
@DenBond7
DenBond7force-pushed the issue_1193_navigation_components branch from 2ff7642 to 6d714dcCompareApril 9, 2022 08:22
@tomholub

tomholub commented Apr 11, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

When do you think this one could be ready? I'll be writing an issue that I think could be worked on after this one merges.

It will be this one #1740 correction, it's this one #1741

@DenBond7

DenBond7 commented Apr 11, 2022

Copy link
Copy Markdown
CollaboratorAuthor

When do you think this one could be ready? I'll be writing an issue that I think could be worked on after this one merges.

I'm on the final touches. I'm working on fixing tests. I hope it will be done this week.

@DenBond7
DenBond7 marked this pull request as ready for review April 15, 2022 08:35
IvanPizhenko
IvanPizhenko suggested changes Apr 15, 2022
View reviewed changes

@IvanPizhenkoIvanPizhenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DenBond7 some minor comments below.

Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/api/email/IMAPStoreManager.kt Outdated
Comment thread...src/main/java/com/flowcrypt/email/ui/activity/fragment/ImportRecipientsFromSourceFragment.kt Outdated
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/ui/activity/fragment/MessagesListFragment.kt Outdated
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/ui/activity/fragment/MessagesListFragment.kt Outdated
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/ui/activity/fragment/base/BaseFragment.kt Outdated
Comment threadFlowCrypt/src/main/res/values-ru/strings.xml Outdated
@DenBond7
DenBond7 merged commit f8d0c48 into masterApr 17, 2022
@DenBond7
DenBond7 deleted the issue_1193_navigation_components branch April 17, 2022 06:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@IvanPizhenkoIvanPizhenkoIvanPizhenko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3.2: App architecture Step 1 + Hand...

Development

Successfully merging this pull request may close these issues.

Migrate to use Fragment where possible Improve Splash screen Migrate to use Navigation component Migrate to use View Binding

3 participants

@DenBond7@tomholub@IvanPizhenko