Skip to content

Issue 1631 tests for sending process - #1719

Merged
DenBond7 merged 7 commits into
masterfrom
issue_1631_tests_for_sending_process
Mar 18, 2022
Merged

Issue 1631 tests for sending process#1719
DenBond7 merged 7 commits into
masterfrom
issue_1631_tests_for_sending_process

Conversation

@DenBond7

@DenBond7DenBond7 commented Mar 17, 2022

Copy link
Copy Markdown
Collaborator

This PR added tests

close#1631

Tests(delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7DenBond7 added the android_testing This label means we need to add an Android test. label Mar 17, 2022
@DenBond7DenBond7 added this to the 1.3.1: App architecture milestone Mar 17, 2022
@DenBond7
DenBond7 marked this pull request as ready for review March 17, 2022 18:16
IvanPizhenko
IvanPizhenko previously approved these changes Mar 17, 2022
View reviewed changes

@IvanPizhenkoIvanPizhenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with couple of comments. Please fix and then can be merged.

Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/service/ProcessingOutgoingMessageInfoHelper.kt Outdated
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/service/ProcessingOutgoingMessageInfoHelper.kt Outdated
@DenBond7
DenBond7 merged commit c756d57 into masterMar 18, 2022
@DenBond7
DenBond7 deleted the issue_1631_tests_for_sending_process branch March 18, 2022 13:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@IvanPizhenkoIvanPizhenkoIvanPizhenko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

android_testingThis label means we need to add an Android test.

Projects

None yet

Milestone

1.3.2: App architecture Step 1 + Hand...

Development

Successfully merging this pull request may close these issues.

Need to add tests for the sending process

2 participants

@DenBond7@IvanPizhenko