Skip to content

Added handling revoked keys on the message compose screen - #1751

Merged
DenBond7 merged 9 commits into
masterfrom
issue_1741_compose_screen_revoked_keys
Apr 22, 2022
Merged

Added handling revoked keys on the message compose screen#1751
DenBond7 merged 9 commits into
masterfrom
issue_1741_compose_screen_revoked_keys

Conversation

@DenBond7

@DenBond7DenBond7 commented Apr 18, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR Added handling revoked keys on the message compose screen

close#1741

Tests(delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7DenBond7 changed the title Added handling revoked keys on the message compose screen. Refactored…Added handling revoked keys on the message compose screenApr 18, 2022
@DenBond7
DenBond7 marked this pull request as ready for review April 21, 2022 11:44
IvanPizhenko
IvanPizhenko suggested changes Apr 21, 2022
View reviewed changes

@IvanPizhenkoIvanPizhenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, questions, suggestions and required changes. Please see my comments.

Comment threadFlowCrypt/src/androidTest/java/com/flowcrypt/email/matchers/BackgroundTintMatcher.kt Outdated
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/security/KeysStorageImpl.kt Outdated
Comment threadFlowCrypt/src/main/res/values-ru/strings.xml Outdated
Comment threadFlowCrypt/src/main/res/values-ru/strings.xml
@DenBond7
DenBond7 merged commit 8459d4f into masterApr 22, 2022
@DenBond7
DenBond7 deleted the issue_1741_compose_screen_revoked_keys branch April 22, 2022 17:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@IvanPizhenkoIvanPizhenkoIvanPizhenko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test/fix how the Android app handles revoked keys from EKM

2 participants

@DenBond7@IvanPizhenko