Skip to content

periodically refresh keys from ekm - #1761

Merged
tomholub merged 29 commits into
masterfrom
issue_1740_periodically_refresh_keys_from_EKM
May 3, 2022
Merged

periodically refresh keys from ekm#1761
tomholub merged 29 commits into
masterfrom
issue_1740_periodically_refresh_keys_from_EKM

Conversation

@DenBond7

@DenBond7DenBond7 commented Apr 26, 2022•
edited by tomholub
Loading

Copy link
Copy Markdown
Collaborator

This PR added the ability to periodically refresh keys from ekm

close#1740

Tests(delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7
DenBond7 marked this pull request as ready for review April 28, 2022 16:10
@DenBond7
DenBond7 requested a review from tomholubApril 28, 2022 16:11
@DenBond7

DenBond7 commented Apr 28, 2022

Copy link
Copy Markdown
CollaboratorAuthor

@tomholub I've added a few places that maybe should be discussed.

tomholub
tomholub reviewed Apr 28, 2022
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go. It's not bad but it's missing one important part: also update keys that are not usable.

Comment thread...pt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/RefreshPrivateKeysFromEkmViewModel.kt
Comment thread...pt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/RefreshPrivateKeysFromEkmViewModel.kt Outdated
Comment thread...pt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/RefreshPrivateKeysFromEkmViewModel.kt
Comment thread...pt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/RefreshPrivateKeysFromEkmViewModel.kt Outdated
Comment thread...pt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/RefreshPrivateKeysFromEkmViewModel.kt Outdated
Comment thread...pt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/RefreshPrivateKeysFromEkmViewModel.kt
Comment thread...pt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/RefreshPrivateKeysFromEkmViewModel.kt Outdated
Comment thread...pt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/RefreshPrivateKeysFromEkmViewModel.kt
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/model/KeyImportDetails.kt
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/ui/activity/MainActivity.kt Outdated
tomholub
tomholub reviewed Apr 29, 2022
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@tomholubtomholub mentioned this pull request Apr 29, 2022
Open
@DenBond7
DenBond7force-pushed the issue_1740_periodically_refresh_keys_from_EKM branch from 61f73f5 to 9f47a47CompareApril 29, 2022 12:02
@tomholub

tomholub commented Apr 29, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

Force-pushing makes it very hard to do code reviews 😞 because then I have to start reviewing all code again, instead of just reviewing delta from last review.

@DenBond7

DenBond7 commented Apr 29, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Force-pushing makes it very hard to do code reviews disappointed because then I have to start reviewing all code again, instead of just reviewing delta from last review.

Ah, sorry. I didn't know that. I will not do it anymore. I've used the logic of wip (work in progress) comment. And pushed it to see what I have to do and what I already have. Sorry again.

@tomholub

tomholub commented Apr 29, 2022

Copy link
Copy Markdown
Collaborator

Force-pushing makes it very hard to do code reviews disappointed because then I have to start reviewing all code again, instead of just reviewing delta from last review.

Ah, sorry. I didn't know that. I will not do it anymore. I've used the logic of wip (work in progress) comment. And pushed it to see what I have to do and what I already have. Sorry again.

No worries. Generally, to make changes in the PR, it's best to add more commits to it. And if you need to bring changes from elsewhere, merge them into here with git merge. It doesn't really matter much before the PR receives its first review, but after that, GitHub forgets what I already reviewed after each force push.

tomholub
tomholub reviewed Apr 29, 2022
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - will take another look

Comment thread...pt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/RefreshPrivateKeysFromEkmViewModel.kt
tomholub
tomholub previously approved these changes Apr 29, 2022
View reviewed changes
@DenBond7DenBond7 mentioned this pull request Apr 29, 2022
Closed
@DenBond7
DenBond7 dismissed stale reviews from IvanPizhenko and tomholub via 98878deMay 2, 2022 13:21
tomholub
tomholub previously approved these changes May 2, 2022
View reviewed changes
IvanPizhenko
IvanPizhenko previously approved these changes May 2, 2022
View reviewed changes
@DenBond7
DenBond7 marked this pull request as draft May 3, 2022 05:25
@DenBond7
DenBond7 dismissed stale reviews from IvanPizhenko and tomholub via 3d4704cMay 3, 2022 05:43
@DenBond7
DenBond7 marked this pull request as ready for review May 3, 2022 16:16
tomholub
tomholub approved these changes May 3, 2022
View reviewed changes
Comment thread...roidTest/java/com/flowcrypt/email/ui/activity/enterprise/MainSignInFragmentEnterpriseTest.kt
@DenBond7DenBond7 mentioned this pull request May 3, 2022
Closed
@tomholub
tomholub merged commit 6e934a0 into masterMay 3, 2022
@tomholub
tomholub deleted the issue_1740_periodically_refresh_keys_from_EKM branch May 3, 2022 16:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomholubtomholubtomholub approved these changes
@IvanPizhenkoIvanPizhenkoAwaiting requested review from IvanPizhenko

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3.3: Periodic refresh from EKM

Development

Successfully merging this pull request may close these issues.

periodically refresh keys from EKM

3 participants

@DenBond7@tomholub@IvanPizhenko