Skip to content

Issue 243 custom chips - #1898

Merged
DenBond7 merged 30 commits into
masterfrom
issue_243_custom_chips
Aug 1, 2022
Merged

Issue 243 custom chips#1898
DenBond7 merged 30 commits into
masterfrom
issue_243_custom_chips

Conversation

@DenBond7

@DenBond7DenBond7 commented Jul 14, 2022

Copy link
Copy Markdown
Collaborator

This PR improved chips

close#243

Tests(delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

DenBond7and others added 30 commits July 9, 2022 14:47
@DenBond7
wip
5753fcf
@DenBond7
wip
4af48ce
@DenBond7
wip
859408d
@DenBond7
wip
ecfc8a2
@DenBond7
Added AutoCompleteResultRecyclerViewAdapter.kt|#234
6345f58
@DenBond7
Modifed RecipientChipRecyclerViewAdapter.|#243
d721b38
@DenBond7
Modifed AutoCompleteResultRecyclerViewAdapter to mark already added r…
6f140a8
…ecipients.| #243
@DenBond7
Added styling chips depend on recipient info.|#243
f19c965
@DenBond7
Modified RecipientsAutoCompleteViewModel to share a search pattern wi…
6a6b5df
…th results.| #243
@DenBond7
Removed 'com.hootsuite.android:nachos:1.2.0' dependency.|#243
a55ed88
@DenBond7
Improved updating autocomplete results.|#243
3a24bde
@DenBond7
wip
7021c2d
@DenBond7
wip
d2857ab
@DenBond7
wip
ebdc18e
@DenBond7
wip
8ba9005
@DenBond7
Added ability to add new emails from list.|#243
de81fc3
@DenBond7
Merge branch 'master' into issue_243_custom_chips
8a98ba8
@DenBond7
Fixed updating recipients list.|#243
f1c418f
@DenBond7
Added "more" label for recipients.|#243
44b2062
@DenBond7
Updated circular progress in recipients chips.|#243
877d2d8
@DenBond7
Added ability to use new chips for "cc" and "bcc". Removed unused res…
a952467
…ources.| #243
@DenBond7
Improved UI.|#243
6f40e2b
@DenBond7
Restored broken functionality.|#243
c4598e0
@DenBond7
Added showing progress when has updating in hidden items.|#243
7017f33
@DenBond7
Fixed a bug in RecipientChipRecyclerViewAdapter.|#243
69ba35a
@DenBond7
Fixed some tests.|#243
207b6a9
@DenBond7
Fixed some more tests.|#243
264c3e9
@DenBond7
Fixed more tests.|#243
02c6f98
@DenBond7
Fixed lint warnings.|#243
e0fbf73
@DenBond7
Fixed compilation issue in SelectRecipientsActivityTest.|#243
2457270
@DenBond7
DenBond7 marked this pull request as ready for review August 1, 2022 07:30
IvanPizhenko
IvanPizhenko approved these changes Aug 1, 2022
View reviewed changes

@IvanPizhenkoIvanPizhenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, couple of questions.

Comment threadFlowCrypt/src/androidTest/java/com/flowcrypt/email/ui/activity/SelectRecipientsActivityTest.kt
Comment threadFlowCrypt/src/androidTest/java/com/flowcrypt/email/ui/activity/SelectRecipientsActivityTest.kt
Comment threadFlowCrypt/src/main/java/com/flowcrypt/email/ui/adapter/RecipientChipRecyclerViewAdapter.kt
@DenBond7
DenBond7 merged commit 124961d into masterAug 1, 2022
@DenBond7
DenBond7 deleted the issue_243_custom_chips branch August 1, 2022 18:27
@DenBond7DenBond7 mentioned this pull request Aug 2, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@IvanPizhenkoIvanPizhenkoIvanPizhenko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Custom chips

2 participants

@DenBond7@IvanPizhenko