Uh oh!
There was an error while loading. Please reload this page.
attester/initial/legacy_submit and welcome message changes - #2012
Merged
Conversation
DenBond7
marked this pull request as ready for review
October 13, 2022 12:19
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
-409
to
-423
| private suspend fun savePrivateKeyToDatabase( | ||
| accountEntity: AccountEntity, | ||
| pgpKeyDetails: PgpKeyDetails, | ||
| passphrase: String | ||
| ) { | ||
| val keyEntity = pgpKeyDetails.toKeyEntity(accountEntity).copy( | ||
| source = KeyImportDetails.SourceType.NEW.toPrivateKeySourceTypeString(), | ||
| privateKey = KeyStoreCryptoManager.encryptSuspend(pgpKeyDetails.privateKey).toByteArray(), | ||
| storedPassphrase = KeyStoreCryptoManager.encryptSuspend(passphrase) | ||
| ) | ||
| if (roomDatabase.keysDao().insertSuspend(keyEntity) == -1L) { | ||
| throw NullPointerException("Cannot save a generated private key") | ||
| } | ||
| } |
CollaboratorAuthor
There was a problem hiding this comment.
Yes. It's unused. I kept this code for some time but after reviewing this class I've decided to remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added API usage changes
close#1984
Tests(delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):