Uh oh!
There was an error while loading. Please reload this page.
Use 'flowcrypt.com/shared-tenant-fes' instead of 'flowcrypt.com/api' - #2171
Conversation
…pt.com/api'. Refactored code.| #2162
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
DenBond7
commented
Jan 25, 2023
@tomholub Please relook the current changes while I'm working on fixing tests. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
… 'useFES' field to 'useCustomerFesUrl'). Refactored code.| #2162
DenBond7
commented
Jan 26, 2023
@tomholub Please relook. I've added the requested changes. |
tomholub
left a comment
There was a problem hiding this comment.
It's improving a lot, see comments
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
… to be able to test different flavors. Refactored code.| #2162
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 5943992 | Generic High Entropy Secret | d3c4d75 | FlowCrypt/src/enterpriseUiTests/res/values/api_keys.xml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
DenBond7
commented
Mar 9, 2023
@tomholub I think I've added changes that were requested to migrate to it means we decide at the setup screen whether will we use a custom FES server or not. After the setup screen, we don't use a custom FES server if it failed at the setup screen. If it is possible I propose adding that functionality via a separate PR. The current PR is already not simple. If yes, I will ask Mart to recheck #2197 and after that, we will be ready to merge it. |
tomholub
commented
Mar 9, 2023
yes, the parts after setup can be done in a future version. so ok for @martgil to re check functionality now |
# Conflicts: # FlowCrypt/build.gradle
DenBond7
commented
Mar 13, 2023
@ioanmo226 Please make the final review. |
DenBond7
commented
Mar 13, 2023
Yes, we are ready to merge it. |
This PR added using 'flowcrypt.com/shared-tenant-fes' instead of 'flowcrypt.com/api'
close#2162
close#2138
Tests(delete all except exactly one):
todo
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):