Uh oh!
There was an error while loading. Please reload this page.
Changed PrepareOutgoingMessagesJobIntentService to WorkManager implementation - #2521
Merged
DenBond7 merged 68 commits intoJan 18, 2024
Conversation
…JobIntentService_to_WorkManager
…JobIntentService_to_WorkManager
…JobIntentService_to_WorkManager # Conflicts: # FlowCrypt/src/main/java/com/flowcrypt/email/service/ProcessingOutgoingMessageInfoHelper.kt # build.gradle.kts
…GmailApiFlow. Refactored code.| #1821
DenBond7
marked this pull request as ready for review
January 18, 2024 08:59
sosnovsky
approved these changes
Jan 18, 2024
sosnovsky
left a comment
Collaborator
There was a problem hiding this comment.
Wow, there are a lot of changes here, but looks good for me - it's well tested and during my testing I haven't noticed any issues, well done 👍
Uh oh!
There was an error while loading. Please reload this page.
DenBond7
deleted the
issue_1821_Migrate_PrepareOutgoingMessagesJobIntentService_to_WorkManager
branch
January 18, 2024 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Changed PrepareOutgoingMessagesJobIntentService to WorkManager implementation
close#1821
Tests(delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):