issue #2158 pgp back to bg script by limonte · Pull Request #2554 · FlowCrypt/flowcrypt-browser

limonte · 2020-02-13T16:59:17Z

tomholub

Code looks good

tomholub · 2020-02-13T20:19:29Z

I'd also look at removing all parentTabId from https://github.com/FlowCrypt/flowcrypt-browser/blob/master/test/tests.json so that they don't cause confusion

tomholub · 2020-02-13T21:14:55Z

 "ゾし逸現飲"
 ],
- "params": "?frameId=none&message=-----BEGIN%20PGP%20MESSAGE-----%0A%0AhQIMA0taL%2FzmLZUBAQ%2F%2BJgpmkgscJEB9uAiFT6TbeZsBqD%2FrRDInab9OevrRBWOZ%0AwQ7UxS4OkM8M1joflEgtP1ZjNkCCuOG5RXR3JZFkUeQbvtMc4mpx%2BOOjYbwHwNNE%0A05wbcIHn380axNPWMYqe8%2FiCK9wFWhMDwtpDfJ0PzLKAhnjFhymMWjmXB2avejaS%0AiaKQRelmUiNt5Tk6FAu8UnOAbr7%2BuLvFBzzjyELL3pGzDBLkawhUT2QZ2nqrC1Ns%0AJ8HEXnl0TBI5T9rlK5i6YQi2i26SWk8QkM0ov5OWVK1qISf15VHeP5uLXch3MfHu%0AEfQEubo378Jbka9QMo1%2FE%2F8ublGQReMpsvbrWto9HqfPSXUGe3hUQcIRi3nKuQBx%0AnbMWonnNE7UEhBFytLL2w%2BMmBDlkePa7zDngOjQwLpYNVvrxJnCjk6Skcrn%2Bx20D%0AYkGziEubqhquMRLxJht4UTLuRSLI8j1NtIRZ5Q9Bi%2B1krSJz527cbq%2FIFBU%2BEmNV%0AfCcR1nYbF5%2FhyTwB7aZQyxCVlRWKlYfwv4%2B7q9cj5wCBuLCY7ZKucEbzodehRcEt%0A4C8Txg2KkD7%2F8%2BTt60KcqjvyDtQkQYNSaubugsG2BAmJpYRU6KFVGDlpNe6gGEQI%0AhnVQq5UaZ9z0DcevE25Xr7fg2mLN7yHRRSauvOGlMnP98d3gDluQlbvAzk5qOMqF%0AAgwDqn0MG9%2BUHywBD%2FsHF58ogxK3kAbITjA453U15KkR4bAqcH343mPfjPOPTyAb%0A3IMoYbQV9SbHuptav6t9rhtrGEkNVunLQLrGYNbwrQx253yqgN%2BdRYD8mn101yJM%0AFcN3R6PDCxAL4hW0cXjSspaqe1mx8U7pz%2BLn1DrC4X8O9HHgMrPvUl18Uc14fAkw%0AZm%2Bwk5vzVYxHp8WsQXb9xpe1imlew7jPuHZkNSA4k6YDoGn%2FwpN3mEOKE3BYq6Ro%0AhnTaapIe%2BJIzsa%2FH0HXKcD0ztFeRUEyyjd%2BdE3vdJYehZrEQIjsM0ocqbn5tcf1W%0A9DP0OXGylTfNbBMT6PQ4N5gfyQDext9Z3QOT0c3HcmUYHJd865jR5nXHGzsGW%2BUr%0Ad0Z6AaCsSCP8WPUNixLzgCdB7EQ6Z5PB4etj9%2BFmKYvEbFiaOr9hrY48ny%2BiOJjq%0As0dudhgZkE8XpA9jcJaGnM4UZdFnssiTydlqaFWYwjVk8d4CsjrsTx%2BJNRWOSVHy%0A9WBbUFQc1eH01rv1sfL467Eyzhh92SCfHooHN9lLtF2mDh43ZQu0ReW8aBd7RzHc%0AKJC8E0wcslzLqfF%2Bx7rh0Vt54Y3i0PS9H9RDWATssCx0V3ySwbnxqme6zIa5qKUN%0AkbSqkucmzZKnaksb46S0zJyOB%2BQV%2F8ntYErmLsX1pGFvPFBm0%2BGQ%2FyQgpUiJhtLp%0AAW8jKCFMyQBHhBKyG0k8Dn9f5mO8rE0xG982m%2BnGwlMKJunn%2Biiyz561V%2F2ebb5e%0ARPCj12RUAIzKicPqRaPCaXhEyD30y1rDCHO7vpCB1CgnbVfRcPvTOOuUlGlrMYWa%0AZlAyrc5RkAiSCLUJab9ZTf%2F%2FT34dmP1p0bmIN3Mnwu3XsbEdZnoQxqPSl0UyfqiL%0A4e5uGe2Za%2FrxykM9CuG0f8vtFWsoNhJkTugdZjfKUZdnyfdsmZhNbKlJcuB7prvb%0A0Gl0%2F3fNns6qv%2B%2BR%2FEGNHbZhSxw%2FqZXGBwGa0Y7hwwsA1Q6ObXgnZA1TDqFUhFk6%0A%2FcDa8FlRD1jj9rKyeuwwLryRy%2FLhoq1LL%2FWV%2BOiUB%2F%2FSldGaHkqXv9%2BCJNhmNwEU%0AiC5mZYyhGGbsVcBxuQigilyMpDQJJfcUiqfN8KL%2BN8ICpnuPGgaMQ97SLeHq2Mmm%0AehcEZwVQZGlCnQJNKmhbqqxJB7WmdBRKTDiBxE5qz5r3grB%2F5v%2BMbyM6G6MyAnkP%0AA%2FUKX0QUZsPDR41XVWhZPTDo%2F%2FZ6aIKJwlgB3E9vak2JkD4%2FpdgzyAM28HOTUyJ%2F%0ASfBVLd%2B%2FjxHIVlm1IaLUAzvJjG0NFlXvD7Pkzs5pXmUf%2F%2FbTdFXNA3uh7VBSGQMl%0AkaeyuemQwiW2Ray4tYbUq%2FFCzl%2B8862JBY98w38natrA%2B%2BWMLHIox0rhMIG%2FvoyK%0AU1%2B2KKgED414MsC309jn%2BP6WCZGKt34BXSfDp%2FRbgwP3X0QIxSYOxtmX8fjKlVPR%0A9FPmkwFvIYsE14MSB16y2vxSEt8JFKoGhXRuVxlGoYuuZrpERfhynnkwSLkw0zln%0AMNUUihw9AePivi6H0qy%2B7DpUy%2B41CW8nxkx%2FdePcdbAq84Y71FyfM7gbLu04EPZ0%0AhTzzgSLDSWvLc7vWRGbqI1erQhfadQwiUzMd0YAyImWmnm003dxfRNNC0oCYDE8V%0A3QGFqOmr4AqcbMGIWBGiP0LajmehJEv%2B8GkIkuDwQRtkgaAkHwDMigujFtraqGEn%0AmduYmYBW88YDsXD9Jv24d4Pt2Ce7P4lc4DEAU3vqUMZFdIwHanjKSNr8O6aXXd0e%0AwrFjc71tUTNGF0suNi%2B74ol0rlS1seQNiijulEW53ngK8z5brNSd1N56H%2FwcYx81%0AqSyeqnGYHphNbpwhBTqHkURBlwygxI2%2BCuMSR96j49ko9AZZHYl6DBAqHLKYWHGi%0AvqvpG%2F%2B%2BFFy0AMSxjs%2F%2FCe5lTS3y3skfneaZ9sgH7o%2BUXCJ7Op%2BmtLdHGjn6%0A%3DGAOS%0A-----END%20PGP%20MESSAGE-----&hasPassword=___cu_false___&msgId=16f66f1da9d50d05&senderEmail=michael%20<censored%40email.com>&isOutgoing=___cu_false___&acctEmail=flowcrypt.compatibility%40gmail.com&parentTabId=0"
+ "params": "?frameId=none&message=-----BEGIN%20PGP%20MESSAGE-----%0A%0AhQIMA0taL%2FzmLZUBAQ%2F%2BJgpmkgscJEB9uAiFT6TbeZsBqD%2FrRDInab9OevrRBWOZ%0AwQ7UxS4OkM8M1joflEgtP1ZjNkCCuOG5RXR3JZFkUeQbvtMc4mpx%2BOOjYbwHwNNE%0A05wbcIHn380axNPWMYqe8%2FiCK9wFWhMDwtpDfJ0PzLKAhnjFhymMWjmXB2avejaS%0AiaKQRelmUiNt5Tk6FAu8UnOAbr7%2BuLvFBzzjyELL3pGzDBLkawhUT2QZ2nqrC1Ns%0AJ8HEXnl0TBI5T9rlK5i6YQi2i26SWk8QkM0ov5OWVK1qISf15VHeP5uLXch3MfHu%0AEfQEubo378Jbka9QMo1%2FE%2F8ublGQReMpsvbrWto9HqfPSXUGe3hUQcIRi3nKuQBx%0AnbMWonnNE7UEhBFytLL2w%2BMmBDlkePa7zDngOjQwLpYNVvrxJnCjk6Skcrn%2Bx20D%0AYkGziEubqhquMRLxJht4UTLuRSLI8j1NtIRZ5Q9Bi%2B1krSJz527cbq%2FIFBU%2BEmNV%0AfCcR1nYbF5%2FhyTwB7aZQyxCVlRWKlYfwv4%2B7q9cj5wCBuLCY7ZKucEbzodehRcEt%0A4C8Txg2KkD7%2F8%2BTt60KcqjvyDtQkQYNSaubugsG2BAmJpYRU6KFVGDlpNe6gGEQI%0AhnVQq5UaZ9z0DcevE25Xr7fg2mLN7yHRRSauvOGlMnP98d3gDluQlbvAzk5qOMqF%0AAgwDqn0MG9%2BUHywBD%2FsHF58ogxK3kAbITjA453U15KkR4bAqcH343mPfjPOPTyAb%0A3IMoYbQV9SbHuptav6t9rhtrGEkNVunLQLrGYNbwrQx253yqgN%2BdRYD8mn101yJM%0AFcN3R6PDCxAL4hW0cXjSspaqe1mx8U7pz%2BLn1DrC4X8O9HHgMrPvUl18Uc14fAkw%0AZm%2Bwk5vzVYxHp8WsQXb9xpe1imlew7jPuHZkNSA4k6YDoGn%2FwpN3mEOKE3BYq6Ro%0AhnTaapIe%2BJIzsa%2FH0HXKcD0ztFeRUEyyjd%2BdE3vdJYehZrEQIjsM0ocqbn5tcf1W%0A9DP0OXGylTfNbBMT6PQ4N5gfyQDext9Z3QOT0c3HcmUYHJd865jR5nXHGzsGW%2BUr%0Ad0Z6AaCsSCP8WPUNixLzgCdB7EQ6Z5PB4etj9%2BFmKYvEbFiaOr9hrY48ny%2BiOJjq%0As0dudhgZkE8XpA9jcJaGnM4UZdFnssiTydlqaFWYwjVk8d4CsjrsTx%2BJNRWOSVHy%0A9WBbUFQc1eH01rv1sfL467Eyzhh92SCfHooHN9lLtF2mDh43ZQu0ReW8aBd7RzHc%0AKJC8E0wcslzLqfF%2Bx7rh0Vt54Y3i0PS9H9RDWATssCx0V3ySwbnxqme6zIa5qKUN%0AkbSqkucmzZKnaksb46S0zJyOB%2BQV%2F8ntYErmLsX1pGFvPFBm0%2BGQ%2FyQgpUiJhtLp%0AAW8jKCFMyQBHhBKyG0k8Dn9f5mO8rE0xG982m%2BnGwlMKJunn%2Biiyz561V%2F2ebb5e%0ARPCj12RUAIzKicPqRaPCaXhEyD30y1rDCHO7vpCB1CgnbVfRcPvTOOuUlGlrMYWa%0AZlAyrc5RkAiSCLUJab9ZTf%2F%2FT34dmP1p0bmIN3Mnwu3XsbEdZnoQxqPSl0UyfqiL%0A4e5uGe2Za%2FrxykM9CuG0f8vtFWsoNhJkTugdZjfKUZdnyfdsmZhNbKlJcuB7prvb%0A0Gl0%2F3fNns6qv%2B%2BR%2FEGNHbZhSxw%2FqZXGBwGa0Y7hwwsA1Q6ObXgnZA1TDqFUhFk6%0A%2FcDa8FlRD1jj9rKyeuwwLryRy%2FLhoq1LL%2FWV%2BOiUB%2F%2FSldGaHkqXv9%2BCJNhmNwEU%0AiC5mZYyhGGbsVcBxuQigilyMpDQJJfcUiqfN8KL%2BN8ICpnuPGgaMQ97SLeHq2Mmm%0AehcEZwVQZGlCnQJNKmhbqqxJB7WmdBRKTDiBxE5qz5r3grB%2F5v%2BMbyM6G6MyAnkP%0AA%2FUKX0QUZsPDR41XVWhZPTDo%2F%2FZ6aIKJwlgB3E9vak2JkD4%2FpdgzyAM28HOTUyJ%2F%0ASfBVLd%2B%2FjxHIVlm1IaLUAzvJjG0NFlXvD7Pkzs5pXmUf%2F%2FbTdFXNA3uh7VBSGQMl%0AkaeyuemQwiW2Ray4tYbUq%2FFCzl%2B8862JBY98w38natrA%2B%2BWMLHIox0rhMIG%2FvoyK%0AU1%2B2KKgED414MsC309jn%2BP6WCZGKt34BXSfDp%2FRbgwP3X0QIxSYOxtmX8fjKlVPR%0A9FPmkwFvIYsE14MSB16y2vxSEt8JFKoGhXRuVxlGoYuuZrpERfhynnkwSLkw0zln%0AMNUUihw9AePivi6H0qy%2B7DpUy%2B41CW8nxkx%2FdePcdbAq84Y71FyfM7gbLu04EPZ0%0AhTzzgSLDSWvLc7vWRGbqI1erQhfadQwiUzMd0YAyImWmnm003dxfRNNC0oCYDE8V%0A3QGFqOmr4AqcbMGIWBGiP0LajmehJEv%2B8GkIkuDwQRtkgaAkHwDMigujFtraqGEn%0AmduYmYBW88YDsXD9Jv24d4Pt2Ce7P4lc4DEAU3vqUMZFdIwHanjKSNr8O6aXXd0e%0AwrFjc71tUTNGF0suNi%2B74ol0rlS1seQNiijulEW53ngK8z5brNSd1N56H%2FwcYx81%0AqSyeqnGYHphNbpwhBTqHkURBlwygxI2%2BCuMSR96j49ko9AZZHYl6DBAqHLKYWHGi%0AvqvpG%2F%2B%2BFFy0AMSxjs%2F%2FCe5lTS3y3skfneaZ9sgH7o%2BUXCJ7Op%2BmtLdHGjn6%0A%3DGAOS%0A-----END%20PGP%20MESSAGE-----&hasPassword=___cu_false___&msgId=16f66f1da9d50d05&senderEmail=michael%20<censored%40email.com>&isOutgoing=___cu_false___&acctEmail=flowcrypt.compatibility%40gmail.com"


There's still a bunch more in this file (every one had a partentTabId - I think without it the frame would show an error). They may be all sorts of strings, I'd remove them all:

tomholub · 2020-02-19T14:47:18Z

GitHub is telling me there's a comment but don't see any, just want to make sure I didn't miss any question :)

limonte · 2020-02-19T18:51:42Z

GitHub is telling me there's a comment but don't see any, just want to make sure I didn't miss any question :)

GitHub will notify about both new commits and new comments in a PR. To ensure there are no unanswered conversations, I'll ping you on conversations waiting for your attention after 24h of inactivity. Would that work for you?

limonte · 2020-02-19T20:29:42Z

@tomholub I stuck on Error: BrowserMsg.sendAwait(pgpMsgDecrypt) returned(null) with lastError: (no lastError) in this case:

/ci_pgp_host_page.htm?account_email=flowcrypt.compatibility%40gmail.com&frame_id=frame_yVMKFLRDiY&message=&has_password=___cu_false___&message_id=1622eaa286f90737&sender_email=human%40flowcrypt.com&is_outgoing=___cu_false___

Looks like const decrypted = await prepared.message.decrypt(privateKeys, passwords, undefined, false); just throwing an undefined exception and I can't figure out why. Could you help me with this one?

tomholub · 2020-02-19T21:00:28Z

GitHub is telling me there's a comment but don't see any, just want to make sure I didn't miss any question :)
GitHub will notify about both new commits and new comments in a PR. To ensure there are no unanswered conversations, I'll ping you on conversations waiting for your attention after 24h of inactivity. Would that work for you?

Definitely

tomholub · 2020-02-19T21:11:08Z

/ci_pgp_host_page.htm?account_email=flowcrypt.compatibility%40gmail.com&frame_id=frame_yVMKFLRDiY&message=&has_password=cu_false&message_id=1622eaa286f90737&sender_email=human%40flowcrypt.com&is_outgoing=cu_false

I'm able to reproduce, and will have a look at this tomorrow.

chrome-extension://nhlmpmiobabndkmnhocbgomijbcmiikg/chrome/dev/ci_pgp_host_page.htm?account_email=flowcrypt.compatibility%40gmail.com&frame_id=frame_yVMKFLRDiY&message=&has_password=___cu_false___&message_id=1622eaa286f90737&sender_email=human%40flowcrypt.com&is_outgoing=___cu_false___

tomholub · 2020-02-19T22:20:35Z

The source of the issue is that the browser keeps sending the messages to both background and the parent tab, but I'm not yet sure how to fix it, tomorrow I'll figure something out.

limonte · 2020-02-20T07:47:31Z

The source of the issue is that the browser keeps sending the messages to both background and the parent tab, but I'm not yet sure how to fix it, tomorrow I'll figure something out.

Not sure if it's related or not, but with changes from this PR I'm facing another issue in Firefox only:

Message is either badly formatted or not compatible with FlowCrypt.
TypeError: openpgp is undefined

when trying to open any encrypted mail from myself. The issue is happening only in Firefox.

tomholub · 2020-02-20T09:22:38Z

Fixed, but only on Chrome. I'll take a look at Firefox

tomholub · 2020-02-20T10:00:21Z

The source of the issue is that the browser keeps sending the messages to both background and the parent tab, but I'm not yet sure how to fix it, tomorrow I'll figure something out.
Not sure if it's related or not, but with changes from this PR I'm facing another issue in Firefox only:
Message is either badly formatted or not compatible with FlowCrypt.
TypeError: openpgp is undefined
when trying to open any encrypted mail from myself. The issue is happening only in Firefox.

Indeed, on Firefox, openpgp.js seems to be undefined in content script. I don't know why, will try a few more things.

limonte · 2020-02-20T10:40:34Z

oops, pushed the commit to the wrong branch, sorry! The commit is reverted.

This reverts commit d80eb4c.

tomholub · 2020-02-20T10:45:29Z

I seem to be running into a wall, OpenPGP.js really cannot be loaded in Firefox content script. That's indeed quite a twist to this set of PRs. I may need to raise this with the OpenPGP.js team.

tomholub · 2020-02-20T10:51:18Z

I'll keep all of the changes that were refactored in these PRs (so that it's easier to switch later) but will start sending the requests back to bg script as before.. until the Firefox situation is understood and resolved.

Sorry that there were so many dragons in this issue, it was completely unexpected.

I'll wrap this up.

start sending pgp request back to backend
add bg pgp handlers
comment non-bg pgp handlers
create an issue to make a repro for OpenPGP.js team to debug Firefox [waiting for v5] OpenPGP.js does not work on Firefox content script #2560
remove openpgp.js from content scripts? (else some functionality may remain broken on FF)
add back PgpMsg.Type call from content script

tomholub

Code ok, need to test FF

tomholub

fixed + tested ff

limonte mentioned this pull request Feb 13, 2020
prep work for manifest V3 - move pgp functionality from background script to content script #2158
Closed

tomholub previously approved these changes Feb 13, 2020
View reviewed changes

limonte dismissed tomholub’s stale review via 7fe19ccFebruary 13, 2020 19:16

tomholub reviewed Feb 13, 2020
View reviewed changes

Limon Monte added 4 commits February 19, 2020 15:44

Move the rest of pgp* listeners from background script
f835193

use ci_pgp_host_page in sendImgAndVerifyPresentInSentMsg()
4f0aa8c

remove parentTabId=0
dad19b8

add BrowserMsg.addPgpListeners() to ComposeRecipientsModule
b5e65bc

limonte force-pushed the issue-2158-move-the-rest-of-pgp-listeners-from-background-script branch from 5ac065b to b5e65bcCompare February 19, 2020 13:44

fix sendImgAndVerifyPresentInSentMsg to take host frame into account
675589b

Limon Monte added 4 commits February 19, 2020 21:11

fix ci_pgp_host_page: set pgp_block iframe width to 100%
e789252

remove &parentTabId= from tests.json
7c7ba3d

remove excessive question mark, it's in location.search
07d8cf9

remove &parent_tab_id=0 from tests.json
3985a38

let browser deliver messages to parent directly
d19a2c8

more precise bg routing to specific frame
309182a

fix types
d80eb4c

Revert "fix types"
eda3dbc
This reverts commit d80eb4c.

tomholub self-assigned this Feb 20, 2020

rename openpgp to opgp
74ebf10

tomholub mentioned this pull request Feb 20, 2020
[waiting for v5] OpenPGP.js does not work on Firefox content script #2560
Closed

Tom J added 5 commits February 20, 2020 11:04

fix test
d61327c

send pgp browsermsg to bg again
a72a533

rm openpgp.js from content scripts
e006341

call BrowserMsg.send.bg.await.pgpMsgType
1a76b24

rm unused import
da7c655

tomholub previously approved these changes Feb 20, 2020
View reviewed changes

addListener -> bgAddListener
4a6ff33

tomholub dismissed their stale review via 4a6ff33February 20, 2020 11:23

tomholub previously approved these changes Feb 20, 2020
View reviewed changes

tomholub changed the title ~~Move the rest of pgp* listeners from background script~~issue #2158 pgp back to bg scriptFeb 20, 2020

fix pgpMsgType
10c1ba8

tomholub dismissed their stale review via 10c1ba8February 20, 2020 11:54

tomholub approved these changes Feb 20, 2020
View reviewed changes

tomholub merged commit 686fcbf into masterFeb 20, 2020

limonte deleted the issue-2158-move-the-rest-of-pgp-listeners-from-background-script branch February 20, 2020 12:03

Uh oh!

Conversation

limonte commented Feb 13, 2020

Uh oh!

tomholub left a comment

Choose a reason for hiding this comment

Uh oh!

tomholub commented Feb 13, 2020

Uh oh!

tomholubFeb 13, 2020

Choose a reason for hiding this comment

Uh oh!

limonteFeb 19, 2020

Choose a reason for hiding this comment

Uh oh!

tomholub commented Feb 19, 2020

Uh oh!

limonte commented Feb 19, 2020

Uh oh!

limonte commented Feb 19, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomholub commented Feb 19, 2020

Uh oh!

tomholub commented Feb 19, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomholub commented Feb 19, 2020

Uh oh!

limonte commented Feb 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomholub commented Feb 20, 2020

Uh oh!

tomholub commented Feb 20, 2020

Uh oh!

limonte commented Feb 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomholub commented Feb 20, 2020

Uh oh!

tomholub commented Feb 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomholub left a comment

Choose a reason for hiding this comment

Uh oh!

tomholub left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

limonte commented Feb 19, 2020•
edited
Loading

tomholub commented Feb 19, 2020•
edited
Loading

limonte commented Feb 20, 2020•
edited
Loading

limonte commented Feb 20, 2020•
edited
Loading

tomholub commented Feb 20, 2020•
edited
Loading