Skip to content

issue 2590 key manager integration - #2597

Merged
tomholub merged 35 commits into
masterfrom
issue-2590-key-manager-integration
Feb 28, 2020
Merged

issue 2590 key manager integration#2597
tomholub merged 35 commits into
masterfrom
issue-2590-key-manager-integration

Conversation

@tomholub

@tomholubtomholub commented Feb 26, 2020•
edited
Loading

Copy link
Copy Markdown
Collaborator

close#2590
close#1500

  • add rules
  • create tests
  • hide Add Key
  • add code to enforce key algo during generating (also during regular keygen)
  • test km not available only after keygen
  • hide pp settings
  • test KS not reachable + add specialized err

@tomholubtomholub changed the title issue 2590 km integrationissue 2590 key manager integrationFeb 26, 2020
@lgtm-com

lgtm-comBot commented Feb 27, 2020

Copy link
Copy Markdown

This pull request introduces 2 alerts when merging 29326c4 into e4df5ce - view on LGTM.com

new alerts:

  • 2 for Conflicting HTML element attributes

@lgtm-com

lgtm-comBot commented Feb 27, 2020

Copy link
Copy Markdown

This pull request introduces 2 alerts when merging d48fc80 into e4df5ce - view on LGTM.com

new alerts:

  • 2 for Conflicting HTML element attributes

tomholub
tomholub commented Feb 27, 2020
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few things to double check and wrap up

Comment threadextension/chrome/settings/setup/setup-key-manager-autogen.ts
Comment threadextension/chrome/settings/setup/setup-render.ts Outdated
tomholub
tomholub commented Feb 28, 2020
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomholub
tomholub marked this pull request as ready for review February 28, 2020 09:16
@tomholub
tomholub merged commit ee43a49 into masterFeb 28, 2020
@tomholub
tomholub deleted the issue-2590-key-manager-integration branch March 24, 2020 09:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FlowCrypt Email Key Manager integration better logging of 500 errors

1 participant

@tomholub