Uh oh!
There was an error while loading. Please reload this page.
Added comments for ContactStore save and update methods - #3551
Conversation
| * The `pubkey` property will be used only to add or update a pubkey record by the pubkey fingerprint. | ||
| * Null value of `pubkey` won't affect any pubkey records. | ||
| * The `pubkeyLastCheck` property can be set to a non-null value only when `pubkey` specified | ||
| * and will be applied only to that specific pubkey record. Missing or null `pubkeyLastCheck` will |
There was a problem hiding this comment.
There is a bit inconsistent behaviour. We can reset name and lastUse properties of the contact by providing null values in the update parameter, whereas pubkeyLastCheck will be ignored if null is provided. It's impossible to reset it. Should we do property existence check on it as with other properties or leave as it is, @tomholub ?
There was a problem hiding this comment.
Name and lastUse should not be ever reset (no point setting name from something to null, and no point setting lastUse from something to null either). Thanks for noticing!
tomholub
left a comment
There was a problem hiding this comment.
I merged this one in - behavior change can be done in a followup PR.
This PR adds description to
saveandupdatemethods ofContactStore.close#3536
Tests(delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):