Skip to content

Never reset Contact's name and lastUse - #3553

Merged
tomholub merged 3 commits into
masterfrom
issue-3552-name-lastuse
Apr 12, 2021
Merged

Never reset Contact's name and lastUse#3553
tomholub merged 3 commits into
masterfrom
issue-3552-name-lastuse

Conversation

@rrrooommmaaa

@rrrooommmaaarrrooommmaaa commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

This PR retains name and lastUse values of existing records
when save or update calls didn't have corresponding non-null values as parameters

close#3552


Tests(delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomholub
tomholub merged commit f690d30 into masterApr 12, 2021
@tomholub
tomholub deleted the issue-3552-name-lastuse branch April 12, 2021 08:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

name and lastUse should not be ever reset

2 participants

@rrrooommmaaa@tomholub