Uh oh!
There was an error while loading. Please reload this page.
Allow to import unarmored S/MIME certificate - #3568
Merged
Merged
Conversation
rrrooommmaaa
commented
Apr 16, 2021
ContributorAuthor
I'll also add advanced email extraction to completely support the provided certificate. |
tomholub
commented
Apr 16, 2021
Collaborator
Excellent! |
| const emails = SmimeKey.getNormalizedEmailsFromCertificate(certificate); | ||
| const key = { | ||
| type: 'x509', | ||
| id: certificate.serialNumber.toUpperCase(), |
ContributorAuthor
There was a problem hiding this comment.
I'm afraid we can't use serialNumber as fingerprint.
Should we open a new task for this as well as include migration to re-calculate ids?
rrrooommmaaa
marked this pull request as ready for review
April 18, 2021 09:56
rrrooommmaaa
commented
Apr 18, 2021
ContributorAuthor
We can merge this, but the original issue is still unresolved due to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to import a certificate in DER format
in addition to already implemented PEM and PKCS#12 PFX formats
issue #3559
Tests(delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):