Skip to content

allow to test manualEnter with keyPath #3528 - #3861

Merged
tomholub merged 3 commits into
masterfrom
issue-3528-key-import
Jul 28, 2021
Merged

allow to test manualEnter with keyPath #3528#3861
tomholub merged 3 commits into
masterfrom
issue-3528-key-import

Conversation

@rrrooommmaaa

@rrrooommmaaarrrooommmaaa commented Jul 28, 2021•
edited by tomholub
Loading

Copy link
Copy Markdown
Contributor

This PR fixes SetupPageRecipe.manualEnter to handle files

close#3528

Tests(delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

tomholub
tomholub reviewed Jul 28, 2021
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 except what seems an accidental change

Comment threadtest/source/test.ts Outdated
tomholub
tomholub previously approved these changes Jul 28, 2021
View reviewed changes
@tomholub
tomholub enabled auto-merge (squash) July 28, 2021 18:20
@tomholub
tomholub merged commit 6cdc487 into masterJul 28, 2021
@tomholub
tomholub deleted the issue-3528-key-import branch July 28, 2021 19:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomholubtomholubtomholub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test importing binary private key from file

2 participants

@rrrooommmaaa@tomholub