Skip to content

initial import of S/MIME key - #3938

Merged
rrrooommmaaa merged 6 commits into
masterfrom
issue-3530-import-unencrypted-smimekey
Sep 8, 2021
Merged

initial import of S/MIME key#3938
rrrooommmaaa merged 6 commits into
masterfrom
issue-3530-import-unencrypted-smimekey

Conversation

@rrrooommmaaa

@rrrooommmaaarrrooommmaaa commented Aug 29, 2021•
edited by tomholub
Loading

Copy link
Copy Markdown
Contributor

This PR enables importing an unencrypted S/MIME PKCS#12 file

Also implements a proper SmimeKey.asPublicKey() method

close#3530

Tests(delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

rrrooommmaaa
rrrooommmaaa commented Sep 3, 2021
View reviewed changes
Comment threadtest/source/tests/setup.ts
@tomholubtomholub mentioned this pull request Sep 6, 2021
Closed
@rrrooommmaaa
rrrooommmaaa marked this pull request as ready for review September 7, 2021 17:33
@rrrooommmaaa
rrrooommmaaa enabled auto-merge (squash) September 7, 2021 17:34
tomholub
tomholub approved these changes Sep 8, 2021
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@rrrooommmaaa
rrrooommmaaa merged commit ef76ca9 into masterSep 8, 2021
@rrrooommmaaa
rrrooommmaaa deleted the issue-3530-import-unencrypted-smimekey branch September 8, 2021 07:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomholubtomholubtomholub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

import decrypted pkcs12 private key

2 participants

@rrrooommmaaa@tomholub