include multiple keys from a single backup by martgil · Pull Request #3973 · FlowCrypt/flowcrypt-browser

martgil · 2021-09-13T08:43:54Z

This PR will:

brings back the green backup button for accounts with multiple private keys but the other doesn't have backup.
backup multiple keys in a single file when the multiple private keys are detected but few are only having backup.

close#2482 // if this PR closes an issue

issue #2806 // if it doesn't close the issue yet

Task list:

backups should contain multiple keys in single file
all protected by the same passphrase. (uncertain. At the moment, I use the passphrase of key[0] which I believe the active key of the user to backup all the keys)
Let user uncheck keys they don't want to back up
Fix button not currently shown.
Missing tests for checkboxes; submitted keys after performing a successful backup

Tests(delete all except exactly one):

Tests will be added later (issue #...)
Tests added or updated

** Incomplete functionalities from issue #2482

Get currently used key and it's associated passphrase when encrypting multiple backup keys.
Render a list of backup (probably a checkboxes) for users to include/exclude keys

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

addresses the issue it closes (if any)
code is readable and understandable
is accompanied with tests, or tests are not needed
is free of vulnerabilities
is documented clearly and usefully, or doesn't need documentation

martgil · 2021-09-13T08:55:18Z

I am really uncertain of this line code. This line of code should be responsible for getting the current primary key being used by the logged-in user. But here I have temporarily use the first primary key which I'm totally uncertain if was really correct by encrypting the backup using the passphrase of the first primary key found.

flowcrypt-browser/extension/chrome/settings/modules/backup-manual-module.ts

Line 82 in 02137ed

constpp=awaitPassphraseStore.get(this.view.acctEmail,primaryKeys[0].fingerprints[0]);

martgil · 2021-09-13T09:25:29Z

Can I also ask for a suggestion on how to generally approach fixing CI-related issues especially on "GMAIL Live tests"?

I already tried running Gmail live tests on my local machine but I think I have missed something.

npm run test_ci_chrome_consumer_live_gmail
flowcrypt-browser@8.1.4 test_ci_chrome_consumer_live_gmail
node ./node_modules/ava/cli --timeout=20m --verbose --concurrency=1 build/test/test/source/test.js -- CONSUMER-LIVE-GMAIL STANDARD-GROUP
TEST_VARIANT: CONSUMER-LIVE-GMAIL:STANDARD-GROUP, (build dir: build/chrome-consumer, poolSizeOne: false)
consts: {"TIMEOUT_SHORT":60000,"TIMEOUT_EACH_RETRY":180000,"TIMEOUT_ALL_RETRIES":780000,"TIMEOUT_OVERALL":840000,"ATTEMPTS":3,"POOL_SIZE":3,"IS_LOCAL_DEBUG":false} ✖ No tests found in build/test/test/source/test.js

github-actions · 2021-09-13T09:25:48Z

There were 1 email addresses found in the above comment. Please:

Click three dots -> edit to remove the email addresses.
Click edited in the comment header, and click on the previous revision of the comment.
When viewing the old revision with an email in it, click options -> delete this revision from history.

limonte · 2021-09-13T20:49:25Z

Can I also ask for a suggestion on how to generally approach fixing CI-related issues especially on "GMAIL Live tests"?

I already tried running Gmail live tests on my local machine but I think I have missed something.

npm run test_ci_chrome_consumer_live_gmail
flowcrypt-browser@8.1.4 test_ci_chrome_consumer_live_gmail
node ./node_modules/ava/cli --timeout=20m --verbose --concurrency=1 build/test/test/source/test.js -- CONSUMER-LIVE-GMAIL STANDARD-GROUP
TEST_VARIANT: CONSUMER-LIVE-GMAIL:STANDARD-GROUP, (build dir: build/chrome-consumer, poolSizeOne: false)
consts: {"TIMEOUT_SHORT":60000,"TIMEOUT_EACH_RETRY":180000,"TIMEOUT_ALL_RETRIES":780000,"TIMEOUT_OVERALL":840000,"ATTEMPTS":3,"POOL_SIZE":3,"IS_LOCAL_DEBUG":false} ✖ No tests found in build/test/test/source/test.js

The problem with Gmail tests is unrelated to this PR and has been fixed. I re-run tests for this PR, they are passing now.

github-actions · 2021-09-13T20:49:42Z

There were 1 email addresses found in the above comment. Please:

Click three dots -> edit to remove the email addresses.
Click edited in the comment header, and click on the previous revision of the comment.
When viewing the old revision with an email in it, click options -> delete this revision from history.

martgil · 2021-09-14T05:26:30Z

Thanks a lot for taking a look, @limonte. The tests are passing now.

Kind Regards,
Mart Gil

…hould-include-multiple-keys

limonte · 2021-09-14T11:00:12Z

+ $('.key_backup_selection').append(dom);
+ }
+ $('.input_prvkey_backup_checkbox').click((event) => {
+ const email = String($($($(event.target).siblings()[0]).children()[0]).children()[0].innerText);


Instead of this spaghetti code I'd recommend this:
<inputclass="input_prvkey_backup_checkbox" type="checkbox" data-email="${primaryKi.emails}">
constemail=$(event.target).data('email');

…hould-include-multiple-keys

…s://github.com/FlowCrypt/flowcrypt-browser

…hould-include-multiple-keys

…s://github.com/FlowCrypt/flowcrypt-browser into issue-2482-backup-should-include-multiple-keys

lgtm-com · 2021-10-13T08:17:27Z

This pull request fixes 1 alert when merging 118f5c4 into aeb1be6 - view on LGTM.com

fixed alerts:

1 for Missing await

lgtm-com · 2021-10-13T09:09:15Z

This pull request fixes 1 alert when merging 911cb96 into aeb1be6 - view on LGTM.com

fixed alerts:

1 for Missing await

lgtm-com · 2021-10-13T10:24:20Z

This pull request fixes 1 alert when merging 3de18e9 into aeb1be6 - view on LGTM.com

fixed alerts:

1 for Missing await

…hould-include-multiple-keys

lgtm-com · 2021-10-15T12:57:31Z

This pull request fixes 1 alert when merging 99b549c into c44ccdb - view on LGTM.com

fixed alerts:

1 for Missing await

lgtm-com · 2021-10-15T14:24:51Z

This pull request fixes 1 alert when merging c268bd4 into 37b5415 - view on LGTM.com

fixed alerts:

1 for Missing await

lgtm-com · 2021-10-15T16:18:07Z

This pull request fixes 1 alert when merging e2cc9a7 into 37b5415 - view on LGTM.com

fixed alerts:

1 for Missing await

…hould-include-multiple-keys

lgtm-com · 2021-10-17T11:19:48Z

This pull request fixes 1 alert when merging 0e777b8 into 37b5415 - view on LGTM.com

fixed alerts:

1 for Missing await

lgtm-com · 2021-10-17T12:28:12Z

This pull request fixes 1 alert when merging edfda59 into 37b5415 - view on LGTM.com

fixed alerts:

1 for Missing await

lgtm-com · 2021-10-18T06:48:30Z

This pull request fixes 1 alert when merging f865df2 into 37b5415 - view on LGTM.com

fixed alerts:

1 for Missing await

lgtm-com · 2021-10-18T08:49:36Z

This pull request fixes 1 alert when merging b143450 into 37b5415 - view on LGTM.com

fixed alerts:

1 for Missing await

lgtm-com · 2021-10-18T14:15:39Z

This pull request fixes 1 alert when merging 60746b0 into 37b5415 - view on LGTM.com

fixed alerts:

1 for Missing await

lgtm-com · 2021-10-18T14:48:40Z

This pull request fixes 1 alert when merging 4ca44cd into 37b5415 - view on LGTM.com

fixed alerts:

1 for Missing await

include multiple keys from a single backup
02137ed

martgil requested a review from rrrooommmaaa as a code owner September 13, 2021 08:43

removed extra spaces
6ba3e16

martgil marked this pull request as draft September 14, 2021 06:00

martgil added 3 commits September 14, 2021 18:34

Add ability to select and deselect key to backup based on fingerprint
0ebb20d

Merge remote-tracking branch 'origin/master' into issue-2482-backup-s…
86b463a
…hould-include-multiple-keys

Fix css error
6165968

limonte reviewed Sep 14, 2021
View reviewed changes

martgiland others added 16 commits September 15, 2021 15:55

Merge remote-tracking branch 'origin/master' into issue-2482-backup-s…
d2c5079
…hould-include-multiple-keys

remove ugly spagetti code; add xss escaped and tags
3025215

apply proper data type to PrvIdentity object
e36c4ed

added failsafe getFirstRequired
dabf24d

added // xss-escaped tag
5894dbc

fix dom ui not to look "stucked"
7f3c062

fix backup not submitting on selection
929425b

Merge branch 'issue-2482-backup-should-include-multiple-keys' ofhttp…
f07b78c
…s://github.com/FlowCrypt/flowcrypt-browser

remove debug code
932f61d

fully functional backups for single and multiple keys
f2e40b3

corrected type String to string
ec7fcc0

Merge remote-tracking branch 'origin/master' into issue-2482-backup-s…
60254cb
…hould-include-multiple-keys

Merge branch 'master' ofhttps://github.com/FlowCrypt/flowcrypt-browser
2a281ae

Merge branch 'issue-2482-backup-should-include-multiple-keys' ofhttp…
d4fc038
…s://github.com/FlowCrypt/flowcrypt-browser into issue-2482-backup-should-include-multiple-keys

move "selectable email listing" to manual backup constructor.
1d453eb

fix floating promise error
662ec29

simplification, avoid warnings in loop
911cb96

more checks
3de18e9

rrrooommmaaa added 2 commits October 15, 2021 12:50

more passphrase tests
630278b

Merge remote-tracking branch 'origin/master' into issue-2482-backup-s…
99b549c
…hould-include-multiple-keys

test fix
c268bd4

test fix
e2cc9a7

rrrooommmaaa mentioned this pull request Oct 17, 2021
Pass phrase dialogs called during backup checks aren't working properly #4059
Open

rrrooommmaaa added 2 commits October 17, 2021 11:13

more scenarios tested
d2ffc7e

Merge remote-tracking branch 'origin/master' into issue-2482-backup-s…
0e777b8
…hould-include-multiple-keys

fix tests
edfda59

rrrooommmaaa mentioned this pull request Oct 17, 2021
Encrypt all keys in backup with the same pass phrase #4060
Open

simplification
f865df2

Improved change_passphrase scenario
b143450

niceties
60746b0

correctly render backup done for both automatic and manual setups
4ca44cd

rrrooommmaaa approved these changes Oct 19, 2021
View reviewed changes

rrrooommmaaa merged commit f0198c0 into masterOct 19, 2021

rrrooommmaaa deleted the issue-2482-backup-should-include-multiple-keys branch October 19, 2021 08:45

Uh oh!

Conversation

martgil commented Sep 13, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To be filled by reviewers

Uh oh!

martgil commented Sep 13, 2021

Uh oh!

martgil commented Sep 13, 2021

Uh oh!

github-actionsBot commented Sep 13, 2021

Uh oh!

limonte commented Sep 13, 2021

Uh oh!

github-actionsBot commented Sep 13, 2021

Uh oh!

martgil commented Sep 14, 2021

Uh oh!

limonteSep 14, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lgtm-comBot commented Oct 13, 2021

Uh oh!

lgtm-comBot commented Oct 13, 2021

Uh oh!

lgtm-comBot commented Oct 13, 2021

Uh oh!

lgtm-comBot commented Oct 15, 2021

Uh oh!

lgtm-comBot commented Oct 15, 2021

Uh oh!

lgtm-comBot commented Oct 15, 2021

Uh oh!

lgtm-comBot commented Oct 17, 2021

Uh oh!

lgtm-comBot commented Oct 17, 2021

Uh oh!

lgtm-comBot commented Oct 18, 2021

Uh oh!

lgtm-comBot commented Oct 18, 2021

Uh oh!

lgtm-comBot commented Oct 18, 2021

Uh oh!

lgtm-comBot commented Oct 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

martgil commented Sep 13, 2021•
edited
Loading

limonteSep 14, 2021•
edited
Loading