Skip to content

issue 3751 use client-configuration endpoint on FES - #4013

Merged
tomholub merged 3 commits into
masterfrom
issue-3751-auth-less-client-configuration
Sep 28, 2021
Merged

issue 3751 use client-configuration endpoint on FES#4013
tomholub merged 3 commits into
masterfrom
issue-3751-auth-less-client-configuration

Conversation

@tomholub

@tomholubtomholub commented Sep 28, 2021

Copy link
Copy Markdown
Collaborator

This PR uses this endpoint https://fes.flowcrypt.com/api/v1/client-configuration?domain=flowcrypt.com (or similar depending on customer domain) to fetch client configuration (org rules) from FES, instead of the /api/v1/account/ endpoint which was authenticated.

This is to avoid relying on a non-OIDC access token, which our customer doesn't prefer.

close#3751


Tests(delete all except exactly one):

  • Tests updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

Comment threadextension/js/common/api/account-server.ts
Comment threadtest/source/mock/fes/fes-endpoints.ts Outdated
Comment threadextension/js/common/api/account-servers/flowcrypt-com-api.ts
@tomholub
tomholub marked this pull request as ready for review September 28, 2021 11:21
@tomholub
tomholub removed the request for review from rrrooommmaaaSeptember 28, 2021 11:22
@tomholub

Copy link
Copy Markdown
CollaboratorAuthor

I'll self-review this because it's due soon for a security penetration testing that was scheduled.

@tomholub
tomholub merged commit f9b0400 into masterSep 28, 2021
@tomholub
tomholub deleted the issue-3751-auth-less-client-configuration branch September 28, 2021 11:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

load Client Configuration from auth-less url on FES

1 participant

@tomholub