Uh oh!
There was an error while loading. Please reload this page.
[WIP] Fix the 'Reply' button behavior, align it with Gmail - #4101
Closed
limonte wants to merge 7 commits into
Closed
[WIP] Fix the 'Reply' button behavior, align it with Gmail#4101limonte wants to merge 7 commits into
limonte wants to merge 7 commits into
Conversation
limonteforce-pushed
the
issue-4077-reply-button
branch
from
November 9, 2021 19:20
2478c5a to
ddd2d3cComparelimonteforce-pushed
the
issue-4077-reply-button
branch
from
November 9, 2021 21:28
a39b3b2 to
77d78fbComparelimonte
commented
Nov 9, 2021
Author
Closing in favor of #4107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the behavior of the 'Reply' button with Gmail:
from !== acctEmail=> reply to thefromemail address onlyfrom === acctEmailthen reply to alltoemail addresses (excludingccandbcc)close#4077
TODO: tests
Tests(delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):