Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 53
Fix the 'Reply' button behavior, align it with Gmail#4107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
e61e17043f92cee1ce0b4df6a27d3b27ba928af7ff77d78fbc4e9b8b2a5a4f1e5592d1File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| Delivered-To: ci.tests.gmail@flowcrypt.dev | ||
| Received: by 2002:a59:cc6d:0:b0:23d:5b31:3e38 with SMTP id k13csp2249506vqv; | ||
| Tue, 9 Nov 2021 15:11:03 -0800 (PST) | ||
| X-Received: by 2002:a5b:287:: with SMTP id x7mr13287353ybl.309.1636499463099; | ||
| Tue, 09 Nov 2021 15:11:03 -0800 (PST) | ||
| ARC-Seal: i=1; a=rsa-sha256; t=1636499463; cv=none; | ||
| d=google.com; s=arc-20160816; | ||
| b=kN0YyvKuy1JOA4t+x9/wkw0QhB9TFgmDk3le7njScFf6TUQKdJ2yXZRH23XCu336tL | ||
| Nw3rXIG4X9SBK0iPYazgpy8vfBeKyGRr866QonBKBS1/EIqghh6KOYVxmjBMLEdGxAKh | ||
| 08dOf0mho7NjSUAlS6guwCBixGkyI0FHqPA8mYyztL4M2nKV5wt4rKo8EdPdHHuhKXY/ | ||
| 4C1nmE02WlaLlcHZkKwgIG9nK5cTcOo0g7iv64IUtyOTuhKst+/lovMQh61QL5Evqzzp | ||
| 8ORca8ivu5s8+wUTATd04VJ6U7x/dBI14qr8qxs0CNYeYPy5Wz41xQidLXGaWfllvU8V | ||
| GWcA== | ||
| ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; | ||
| h=to:subject:message-id:date:mime-version:from:openpgp:dkim-signature; | ||
| bh=4nugcOnQp5fNZoeOnEofc2DcNIDyReG94YZZ5yBCiHg=; | ||
| b=VHGpzi5kE8cYTmuStEW3LOAp699xAk2JnQTHwF2ln9LvU3xTsDp0kJRriplciUr9Aa | ||
| Ejr/KI6LZE2qxmIRvMGVJq8OC1vJo+KNH5ZQH8rgugYZe4Dl9jhGQb7hvGAAFK6g5Xt9 | ||
| 5CxZskAPc/bKk+wjdOQI1SMMzSKWNv0EbfpLy59GzNpoua2abs+BJ1v7+LJFzCb0DUmR | ||
| tWUt0/QvNOx/CiCiZaJYzlJC6NyqbS057jknNzE3oBQqgy1ixXu3hxSAAxv0T8o01MKu | ||
| h4J16P9NTy4X13q0LXTdi+4QdPuA3tJRSTK+J4kLtHj7ttx6rY3nKza0vkeowKilhwc4 | ||
| mD3g== | ||
| ARC-Authentication-Results: i=1; mx.google.com; | ||
| dkim=pass header.i=@gmail.com header.s=20210112 header.b=Hf7d+HCA; | ||
| spf=pass (google.com: domain of limon.monte@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=limon.monte@gmail.com; | ||
| dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com | ||
| Return-Path: <limon.monte@gmail.com> | ||
| Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) | ||
| by mx.google.com with SMTPS id j82sor8078713ybc.0.2021.11.09.15.11.03 | ||
| for <ci.tests.gmail@flowcrypt.dev> | ||
| (Google Transport Security); | ||
| Tue, 09 Nov 2021 15:11:03 -0800 (PST) | ||
| Received-SPF: pass (google.com: domain of limon.monte@gmail.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; | ||
| Authentication-Results: mx.google.com; | ||
| dkim=pass header.i=@gmail.com header.s=20210112 header.b=Hf7d+HCA; | ||
| spf=pass (google.com: domain of limon.monte@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=limon.monte@gmail.com; | ||
| dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com | ||
| DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; | ||
| d=gmail.com; s=20210112; | ||
| h=openpgp:from:mime-version:date:message-id:subject:to; | ||
| bh=4nugcOnQp5fNZoeOnEofc2DcNIDyReG94YZZ5yBCiHg=; | ||
| b=Hf7d+HCAve+o2Pl9ojrLvflrO4EV0dGEWwxKkvDs/o9NPw7+/qFB1J2iuAzwjtTu61 | ||
| INyX3XYcN0iojLpxnodds8V/zygPTV+hxg+dIGmlv1cOI42Ss20Zc0kb7eJi+25WATjG | ||
| hLESCX2n+ilCwpd4WY2PtN5c5go+2kzdYId+KIYIgZd7Lza/vLRaKZXYCsLNsax8aDpY | ||
| AJ9PIYaKSB+5OSFHPz8tnEHT9v5X/yCm5yoyhRbeak3HSxLQ0JKhVcmKU7qcxjjUaK3Z | ||
| XPetfArbW/3J84YT1JiQtJdqR3VGYEG+2FExlfaLGQpL4nayx8FUD07m++7lLHXupHSp | ||
| c0XA== | ||
| X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; | ||
| d=1e100.net; s=20210112; | ||
| h=x-gm-message-state:openpgp:from:mime-version:date:message-id | ||
| :subject:to; | ||
| bh=4nugcOnQp5fNZoeOnEofc2DcNIDyReG94YZZ5yBCiHg=; | ||
| b=dVuQqzIWRLAGlCXL/3qYOawMPMpQ+yOphf9m1IbmDj0G6VGbZtmc9cUk9CVsBpofKO | ||
| YRBC+fuYT6xSeZ73CDvxi84Xm2hoeFzd229bh7be7Smcl0XHVDmBU0VooPtFLQNtLGUT | ||
| IB+Xsx9vfAUqngGyI66KbJdH2y/rNA29AbrVIu0yTeVNUuMbLfYm0aP4yHZtcN+pVdQA | ||
| vNvf3458Yo5J5Ke0Cwuj9xS3caBTeL3tB2FC5ZHZ/I4SOXUIdZklazqyuRoIaz9AU7Mj | ||
| N0ooKC1o8ZGLSZpWyyl+8xbYyXklg0Z8JIohdsaHg5T81bmIEn+K5H3QfTJXnCB+xDe2 | ||
| ++wA== | ||
| X-Gm-Message-State: AOAM530N1MtpBbnxT0g4g/xL0lhznTgIKjbd1wXjmQSe0CKt89S8jjjt | ||
| dD+/qEtUxk3AUEVW8psSlpLX2ocsywRisSZV7UT3DJhcNxk= | ||
| X-Google-Smtp-Source: ABdhPJybhAXlluiEns3dcJPX0CRwomea7nvjZ/FwfLh1G4gxRajFqEgAsiRMbF8fmgOJONhlUxlqy7uSix44mpIMM7Q= | ||
| X-Received: by 2002:a25:d09:: with SMTP id 9mr12729513ybn.401.1636499462534; | ||
| Tue, 09 Nov 2021 15:11:02 -0800 (PST) | ||
| Received: from 717284730244 named unknown by gmailapi.google.com with | ||
| HTTPREST; Tue, 9 Nov 2021 15:11:02 -0800 | ||
| Openpgp: id=B36245FDAC2FBF3D | ||
| From: Limon Monte <limon.monte@gmail.com> | ||
| MIME-Version: 1.0 | ||
| Date: Tue, 9 Nov 2021 15:11:02 -0800 | ||
| Message-ID: <CALMoCt=ofmzffi+6LcEh=RK+ZTRd9=jc4rJXQvWvkDL-BpArQg@mail.gmail.com> | ||
| Subject: [ci.test] encrypted email for reply render | ||
| To: Gmail CI Test <ci.tests.gmail@flowcrypt.dev>, | ||
| Vladimir at FlowCrypt <vladimir@flowcrypt.com> | ||
| Content-Type: text/plain; charset="UTF-8" | ||
| -----BEGIN PGP MESSAGE----- | ||
| Version: FlowCrypt Email Encryption 8.1.5 | ||
| Comment: Seamlessly send and receive encrypted email | ||
| wV4DeWfgCtVtdnoSAQdAdEAJmyVL2xMECqIxIp7Li1s/Jg2VM4JqhWcGNktk | ||
| 1CwwGy1Mimit2hpjCmVsX/EYR5uCWjF+UD5BLTMMjSIbugMit8pKSjmGMm0C | ||
| XOQ4SK0VwcFMA9LAaV92XpwYAQ//Sg01BFCBFRylPNaJG/a39zr9GjF3KVA2 | ||
| mDAHq8gsDjhzfA3a8E4s/z+x3AlgwSH6urShCVcHx/8QZN27xSEYJg5M7rtf | ||
| IyB2Nm87Oin9cyVqteKOlNt6dI7H36zhyPm6EM67IE2CnkuNtXbfAFHN/mKC | ||
| V5TFsHHfWs6nRqAAUnhpNd1o1fClXiavJ8AzOrxKUCIFayZ2V5PGuAudlc/K | ||
| HMM6Ls/xzl07WXVYu0V8J2v0nSD6p7D0GYjVOnJyZpTolRVZBvbDynM/O5no | ||
| EqrAl7HluBQuh9EDtyp1u3OY6mEgOeIUXkh0zSE08MTdhk+vI9m72CKnE7ul | ||
| LludK/5Hd4Da9S6MNhNU+alaTBRDgcInmT3U7DgJ9yiVh9+57HshyGUMjCvx | ||
| zCOQENrnHqUMBmBXmmIoSh0tiWgwdQbK7NxVrJXpAzVgZAtvxSXd7NKkMmjo | ||
| hRtnjGWbuIwrGPhLIvtYDIkUk1TYvQNGpBQeufYZlZGD/Ki/OORb8hIQ4umj | ||
| R8pyD7M5F9MI1MOPHfXDNP3u7ykWfGMK1tLKDFukVxsF1lf4BA6bNxKqOR9J | ||
| R7LHa1RzkCrLADBxIZMj86kesMz/wg+TBl5t83GldsqZpQbU6LwR+uglL67X | ||
| 9TH4e4k23z/t2KxSvdhnTaQ9JtD2rl48+nZP3hkVTAthgxm3i3zBwUwDJIIo | ||
| LVyt6wMBD/0Y5a6uR7+urVOCDcusTW9IoaObr0fBKJtV/bB0D6s18fhJfmBs | ||
| QN2ikl/TE7dldsyLm8LgbAnksqlo3AEMSeq+3Sdz4EZr6OarJlSXqBDrJw12 | ||
| mloD4Sw5pe6Nt2z5byCidLaGGHsK8i3JXvi1Al7S9QPvJ79EMEVN2YUDmiJK | ||
| wiknVJgcRio5rTfpNBy0AzkSz2Gj6I4Cva90nVCdjv6LScku1zxPbfANl4o/ | ||
| 2VNNleSC0hVakPpDra4/njnDHMRA8DZM4tLCvQ5XvBb+r9453DNl5cuJB1FB | ||
| YLRiqw8iSDJ2z2uM06uYv1RHyXAjbj7cXhtVQ2IK5qeyvzHJT/kDXUgBp6Yq | ||
| gMbz3GB8Qb/XlwOD1KRSlsxcJJDgpDPP8L1CofS81dS6NLnxZft3PGW30p2S | ||
| Jy0B/0RI8beH/yVANouNS2cOZ5zw4+oabpugrXmNe3p6evgT1eUrkXE0jryS | ||
| RUmNfvf6M7qhVj8LInt3nHlr7XjS57ubvihFvLFL4T05dnm6JJO34dz0VK7K | ||
| OCMJdd8k+2Q5IKALZtAwGUZmrvqfD6Qzc5qS0KbtbsIi4XmWEFHa4FEIoGgW | ||
| Y6DTw/a+KO7BDbpp3Ul5k8yF413pPgWr2t/haADjYinUn45A+ZYm/aKcJC37 | ||
| edTpIQKwje5FuGKUrH1XauL133+wlY3oF9LChAG/hEw0saKdfC73xDkrdm5r | ||
| s+wmD8G/S0mqRMnU3gsJ3sp499RvmxDGlrGdc808OetfAHP38LP1uv6QGWX1 | ||
| eG00wH7qjHMzHU7UqhGk1GF9X/mnMfSXPqQltXCE/QUFbwlVQu6BQTHMKfuN | ||
| nlA7Qv+vaTNqNdHCA2Qo1mkzBo5o+KJqaFNiaAZPOaW0mmoWDAEJ9wMNOfTa | ||
| oqQ3r+fbCQK/d9RhA5ylOypOL+A7sDXTvbN7T+K6pGsfVINkHeEddWm32OCU | ||
| zFLPYonDjxp7gJFLzNRHenad2DCXTtxlmlGsoqY9KMXttRFCG/6TdfCcGEEc | ||
| 9UD5pqLMtrTO8etBGjH0Cttr6ygflEJrIGua9Y6E0Tw6nzW9gBZZsCHka8ie | ||
| ybHqFM0TWJm8kcwZ+TZZGaWY1W9fGNWXBigxiv39Av3Rh5ZWmuxsPMwacxZ4 | ||
| 6hxUPk1RxvqZP+lkS5wJDrQVSw5+ZtrYFr4NvtlbMuBtj0Nq1IpMDWpbtJlC | ||
| 3h1cQqaQU5wviGtYJvr9wMheVFPISHHP+1yJKDrSijRhGIjDsBryta3i+9rU | ||
| 29lNDO1HuPGuZXNYI09uyXB9OUMch8+a1TGnf6v6czPyo3mk0VNQHlLNTT1d | ||
| cmGF4eYiaqkAXT9TltWotfdgWpLCyE4/5pxbBWzeQ8ENbNzmkM4ed6ZbsnSR | ||
| 3xOgswW/8yKgf/iW9STnon1DbOaaFJT6yimTE9s8Nz/XnWjui5PzVkq6On6C | ||
| /pqClypjVovhjy3PQ+bAlFNWvz5i4VlJZmgBOphwzISrEFTS/SpzhC3PYOsl | ||
| qSqvxAtDTpj8XY9gxIKlU/ArkSxVf51RKxhUvJzDHg2Y+jMGRoHCq0plvX87 | ||
| MDT5ENbx1H99XFJKhhfKI1DVLyHfvmdkf0UIsb9pbwIgbr3S23x7txYPGalD | ||
| mmEbXsVk+1TH6m4ZaDub04T5jLwBU8IpaS6BIUj29nOFtn9dS4lLjm4+i2y2 | ||
| 5RBNYM6VQLJHgX658btEc6DdrzMroS2R0k45pCgJK2upCZm6OspkEfaP8sDU | ||
| 1i9E6SEEEGZsWKmXrDgxg5b/w2Yy/CocmcQwFmB2hrq3PFufd3GUl3iaPQAE | ||
| VWgX0BMTAhZh | ||
| =i5bc | ||
| -----END PGP MESSAGE----- |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1342,6 +1342,34 @@ export const defineComposeTests = (testVariant: TestVariant, testWithBrowser: Te | ||
| await expectRecipientElements(composePage, { to: [], cc: [], bcc: [] }); | ||
| })); | ||
| ava.default('compose - reply - from === acctEmail', testWithBrowser('compatibility', async (t, browser) => { | ||
| const appendUrl = 'threadId=17d02296bccd4c5c&skipClickPrompt=___cu_false___&ignoreDraft=___cu_false___&replyMsgId=17d02296bccd4c5c'; | ||
| const composePage = await ComposePageRecipe.openStandalone(t, browser, 'compatibility', { appendUrl, hasReplyPrompt: true }); | ||
| await composePage.waitAndClick('@encrypted-reply', { delay: 1 }); | ||
| await expectRecipientElements(composePage, { to: ['flowcrypt.compatibility@gmail.com', 'vladimir@flowcrypt.com'], cc: [], bcc: [] }); | ||
| })); | ||
| ava.default('compose - reply - from !== acctEmail', testWithBrowser('compatibility', async (t, browser) => { | ||
| const appendUrl = 'threadId=17d02268f01c7e40&skipClickPrompt=___cu_false___&ignoreDraft=___cu_false___&replyMsgId=17d02268f01c7e40'; | ||
| const composePage = await ComposePageRecipe.openStandalone(t, browser, 'compatibility', { appendUrl, hasReplyPrompt: true }); | ||
| await composePage.waitAndClick('@encrypted-reply', { delay: 1 }); | ||
| await expectRecipientElements(composePage, { to: ['limon.monte@gmail.com'], cc: [], bcc: [] }); | ||
| })); | ||
| ava.default('compose - reply all - from === acctEmail', testWithBrowser('compatibility', async (t, browser) => { | ||
| const appendUrl = 'threadId=17d02296bccd4c5c&skipClickPrompt=___cu_false___&ignoreDraft=___cu_false___&replyMsgId=17d02296bccd4c5c'; | ||
| const composePage = await ComposePageRecipe.openStandalone(t, browser, 'compatibility', { appendUrl, hasReplyPrompt: true }); | ||
| await composePage.waitAndClick('@action-accept-reply-all-prompt', { delay: 1 }); | ||
| await expectRecipientElements(composePage, { to: ['flowcrypt.compatibility@gmail.com', 'vladimir@flowcrypt.com'], cc: ['limon.monte@gmail.com'], bcc: ['sweetalert2@gmail.com'] }); | ||
| })); | ||
| ava.default('compose - reply all - from !== acctEmail', testWithBrowser('compatibility', async (t, browser) => { | ||
| const appendUrl = 'threadId=17d02268f01c7e40&skipClickPrompt=___cu_false___&ignoreDraft=___cu_false___&replyMsgId=17d02268f01c7e40'; | ||
| const composePage = await ComposePageRecipe.openStandalone(t, browser, 'compatibility', { appendUrl, hasReplyPrompt: true }); | ||
| await composePage.waitAndClick('@action-accept-reply-all-prompt', { delay: 1 }); | ||
| await expectRecipientElements(composePage, { to: ['limon.monte@gmail.com', 'vladimir@flowcrypt.com'], cc: ['limon.monte@gmail.com'], bcc: [] }); | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we really need Author There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. | ||
| })); | ||
| /** | ||
| * You need the following lines in /etc/hosts: | ||
| * 127.0.0.1 standardsubdomainfes.test | ||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange that
flowcrypt.compatibility@gmail.comis included intowith "reply", whereas it's not included with "reply all". Is there a purpose of such behaviour?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My goal here was to align the behavior with Gmail so there will be no surprises for our users.
In this particular case
flowcrypt.compatibility@gmail.comsends the messagetoflowcrypt.compatibility@gmail.com(itself,from === acctEmail)vladimir@flowcrypt.comcclimon.monte@gmail.combccsweetalert2@gmail.comHere's the Gmail's behavior which is aligned with the test's expectations:
You can test it by yourself by logging into
flowcrypt.compatibility@gmail.comand opening this thread https://mail.google.com/mail/u/4/#inbox/WhctKKXHCWWrrFvSmnhdCjDHBtHBbzrqmFPQWKBVqftJdVQFxGtTTPDWZrvZKPXlJpckmNL