Skip to content

render text prior to signature verification - #4199

Merged
tomholub merged 1 commit into
masterfrom
issue-4197-fetch-text-before-signature
Dec 16, 2021
Merged

render text prior to signature verification#4199
tomholub merged 1 commit into
masterfrom
issue-4197-fetch-text-before-signature

Conversation

@rrrooommmaaa

@rrrooommmaaarrrooommmaaa commented Dec 16, 2021

Copy link
Copy Markdown
Contributor

This PR renders text prior to signature

close#4197 // if this PR closes an issue


Tests(delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@rrrooommmaaa
rrrooommmaaa marked this pull request as ready for review December 16, 2021 15:48

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks to be exactly it 👍

@tomholub
tomholub merged commit 5d170c4 into masterDec 16, 2021
@tomholub
tomholub deleted the issue-4197-fetch-text-before-signature branch December 16, 2021 15:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make sure that fetching verification pubkeys does not delay message rendering

2 participants

@rrrooommmaaa@tomholub