Uh oh!
There was an error while loading. Please reload this page.
Change key type into key family - #4393
Merged
Merged
Conversation
| <div class="line left"> | ||
| <label> | ||
| Encryption key type: | ||
| Encryption key family: |
Collaborator
There was a problem hiding this comment.
Here the "key type" referred to algorithms, not openpgp vs x509
IvanPizhenko
marked this pull request as ready for review
April 11, 2022 19:37
IvanPizhenko
commented
Apr 11, 2022
ContributorAuthor
@tomholub@rrrooommmaaa Ready for review |
rrrooommmaaa
suggested changes
Apr 12, 2022
rrrooommmaaa
left a comment
Contributor
There was a problem hiding this comment.
we actually need to rename all the related internal variables too
| const keyTypes = new Set(pubkeys.map(k => k.family)); | ||
| if (keyTypes.has('openpgp') && keyTypes.has('x509')) { | ||
| throw new Error('Mixed key types are not allowed: ' + [...keyTypes]); | ||
| throw new Error('Mixed key families are not allowed: ' + [...keyTypes]); |
Contributor
There was a problem hiding this comment.
and please rename the keyTypes variable too, while you're at it.
IvanPizhenko
commented
Apr 13, 2022
ContributorAuthor
@rrrooommmaaa Renamed that variable, please recheck |
rrrooommmaaa
approved these changes
Apr 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes "key type" into "key family".
close#4376
Tests(delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):