Uh oh!
There was an error while loading. Please reload this page.
#3448 Ignore signature for pubkey in protonmail - #4985
Merged
rrrooommmaaa merged 7 commits intoMar 3, 2023
Conversation
rrrooommmaaa
commented
Mar 1, 2023
ContributorAuthor
added 5 commits
March 1, 2023 15:23
…ubkey-signature-attachment
…ubkey-signature-attachment
rrrooommmaaa
marked this pull request as ready for review
March 3, 2023 12:42
rrrooommmaaa
enabled auto-merge (squash)
March 3, 2023 12:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The fixed code doesn't process the signature attachment of a pubkey supplied by Protonmail
and hides it
close#3448
Also mocks text/plain and attachment rendering for GmailElementReplacer mock tests #4810
Tests(delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):