Skip to content

Fatal error message is shown when cancelling Google login - #1189

Merged
tomholub merged 4 commits into
masterfrom
feature/issue-1185
Dec 9, 2021
Merged

Fatal error message is shown when cancelling Google login#1189
tomholub merged 4 commits into
masterfrom
feature/issue-1185

Conversation

@ivan-ushakov

@ivan-ushakovivan-ushakov commented Dec 7, 2021

Copy link
Copy Markdown
Contributor

close#1185


Tests(delete all except exactly one):


To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

Comment threadFlowCrypt/Functionality/Services/GlobalRouter.swift Outdated
Comment threadFlowCrypt/Functionality/Services/GlobalRouter.swift Outdated

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking with changes requested as above, for clarity

@ivan-ushakov

Copy link
Copy Markdown
ContributorAuthor

SendEmailToRecipientWithoutPublicKey.spec.ts works locally, so I run UI tests again

@tomholub
tomholub enabled auto-merge (squash) December 9, 2021 18:02
@tomholub
tomholub merged commit fb8818b into masterDec 9, 2021
@tomholub
tomholub deleted the feature/issue-1185 branch December 9, 2021 19:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fatal error message is shown when cancelling google login

2 participants

@ivan-ushakov@tomholub