issue #193 add attachment nodes by qsoftdevelopment · Pull Request #295 · FlowCrypt/flowcrypt-ios

qsoftdevelopment · 2021-04-28T13:43:08Z

This is a draft PR to check whether or not we're on a good path. Please note that most issues come with using Texture, since we're unfamiliar with it, so here you can find two attachments hardcoded and shown in every email just to check if nodes and this approach are correct.

tomholub · 2021-04-28T13:44:48Z

@Kharchevskyi please have a look at the rendering parts. Thanks!

Kharchevskyi · 2021-04-29T19:40:59Z

In general looks good 👍

tomholub · 2021-04-30T08:45:56Z

I should also clarify: as long as the visual doesn't look broken, some ugliness is OK at this stage. Functionality is a lot more important at this stage then looks. There will be a time that we refurbish the app for looks sometime in 2022 but this year we won't have time for that, so a few rough edges in UI are ok. This also applies to PR reviews - the first focus is functionality and correctness (and usability), and visual appeal is secondary.

tomholub · 2021-04-30T08:46:37Z

@Kharchevskyi how do you propose this type of functionality should be tested?

Kharchevskyi · 2021-04-30T08:51:45Z

As I understand there is only UI added in this PR.
I think it should be tested when "parsing" functionality will be in place

tomholub · 2021-04-30T08:58:18Z

As I understand there is only UI added in this PR.
I think it should be tested when "parsing" functionality will be in place

Definitely - once functionality is in place, what should be the way to test this? With you answer, we should probably update readme to document a clear overview of our approach to testing.

Kharchevskyi · 2021-05-02T11:56:05Z

@tomholub Testing is quite specific task by task. For this task I think expected result is that Attachment block is present in messages where they are. They coloured in correct colour. Toast is shown when tapping on attachment.
I think better to have some "expected result" when describing GH issue.

tomholub · 2021-05-03T17:37:47Z

@tomholub Testing is quite specific task by task. For this task I think expected result is that Attachment block is present in messages where they are. They coloured in correct colour. Toast is shown when tapping on attachment.
I think better to have some "expected result" when describing GH issue.

Yes, but more specifically - are we pulling messages from live Gmail API to test this? Or do we mock it? Or a unit test? This is what we need to make some standardization and guidance for, else contributors will not know what type of test to write and how.

Kharchevskyi · 2021-05-05T09:13:33Z

Yes, we use Gmail API to test functionality.
I do remember it was a plan to mock some Mail API, is it already implemented? Can we use it on iOS?

Unit test - good question. We do not have a lot of unit tests now. But I do think we need to work on it and add some scope in each PR for writing tests. Or even cover some previous implementation with tests

tomholub · 2021-05-05T09:35:51Z

We don't have any mock API available for iOS testing yet. On Android, we test though IMAP where we have a mock server. That produces a pretty decent testing ergonomy. While it doesn't test the Gmail API vs IMAP/SMTP layer, it's pretty small difference.

That means for this test, we would test by opening an actual Gmail message, on live Gmail servers like other tests, and testing through the UI - because that's about the only thing we are set up for, for now. correct?

Kharchevskyi · 2021-05-05T17:24:03Z

Is it possible to somehow share this IMAP server?

Yes, for now all tasks like that can be tested only with real Gmail account. Usually I use accounts from `test-ci-secrets.json"

tomholub · 2021-05-05T18:27:32Z

Let's skip tests on this PR, and we'll do manual testing for this one. Then we'll set up tests afterwards with mock IMAP server.

tomholub · 2021-05-05T18:28:29Z

@qsdemir how is this coming along, could we get this in mergeable state soon?

ghost · 2021-05-07T08:27:06Z

@tomholub @Kharchevskyi Hi, can you please take a look into this again?

tomholub · 2021-05-07T08:28:49Z

@qsdemir you can mark the PR ready for review if you think it's good for review / potential merging.

@seisvelas please build and run this to check the functionality

@Kharchevskyi please have a look at the code

Kharchevskyi · 2021-05-07T08:50:56Z

 private let messageProvider: MessageProvider
 private let messageOperationsProvider: MessageOperationsProvider
 private var message: NSAttributedString
+ private var attachments: [Attachment]


you can initiate it here instead of inside init private var attachments: [Attachment] = []

Kharchevskyi · 2021-05-07T09:32:23Z

 isEmail: true
 )
 let decryptErrBlocks = decrypted.blocks.filter { $0.decryptErr != nil }
+ let decryptAttBlocks = decrypted.blocks.filter { $0.type == .plainAtt || $0.type == .encryptedAtt || $0.type == .decryptedAtt }


I would suggest to have some computed property for MsgBlock and cover it with tests(not in scope of this PR)
extension MsgBlock { var isAttachmentBlock: Bool { type == .plainAtt || type == .encryptedAtt || type == .decryptedAtt } }

It would be called isAttachmentBlock. But this is rather minor as you say

Kharchevskyi · 2021-05-07T09:35:47Z

 let decryptErrBlocks = decrypted.blocks.filter { $0.decryptErr != nil }
+ let decryptAttBlocks = decrypted.blocks.filter { $0.type == .plainAtt || $0.type == .encryptedAtt || $0.type == .decryptedAtt }
+
+ let attachments = decryptAttBlocks.map { Attachment(name: $0.attMeta?.name ?? "Attachment", size: $0.attMeta?.length ?? 0) }


same for Attachment. You can have
extension Attachment { init(block: MsgBlock) { self.name = self.size = } }
and then it can be just
let attachments = decrypted.blocks .filter(\.isAttachmentBlock) .map(Attachment.init)
this solution is more flexible and can be tested easily.

Kharchevskyi · 2021-05-07T09:41:31Z

+ attachmentNodes = attachments.map { AttachmentNode(input: AttachmentNode.Input(name: $0.name, size: $0.size),
+ onTap: {
+ self.onTap?()
+ })
+ }


please change indentation here? hard for understanding
attachmentNodes = attachments.map { input: AttachmentNode( input: onTap: ) ) }

Can xcode be set to indent automatically on save?

We already have a script for that. Will check if it's possible to indent code during build phase.
Will work on it ASAP to prevent all this "code style" comments

Kharchevskyi · 2021-05-07T09:47:19Z

@qsdemir good job 👍
Please fix some small comments and improvements

qsoftdevelopment · 2021-05-07T12:03:05Z

@qsdemir you can mark the PR ready for review if you think it's good for review / potential merging.
@seisvelas please build and run this to check the functionality
@Kharchevskyi please have a look at the code

@tomholub Thanks. I was not aware of this button Redy for review.

tomholub · 2021-05-07T12:47:44Z

I just realized @seisvelas cannot run this due to #285 . I'll test this myself for now until that is resolved.

tomholub

I've tested the functionality, looks good. We can address the style and simplification review points made by Anton in another PR later.

issue#193add attachment nodes
661a61d

qsoftdevelopment requested review from Kharchevskyi and tomholub April 28, 2021 13:43

tomholub removed their request for review April 28, 2021 13:44

Kharchevskyi reviewed Apr 29, 2021
View reviewed changes

QSD_e added 3 commits May 5, 2021 20:37

Parse decrypted blocks
d623fd8

issue#193Update color for AttachmentNode icons
ae373d5

issue#193parse attachment name and file size
30b3df3

seisvelas self-assigned this May 7, 2021

Kharchevskyi suggested changes May 7, 2021
View reviewed changes

qsoftdevelopment marked this pull request as ready for review May 7, 2021 12:03

Merge branch 'master' into feature/issue-193-attachmentsList
27b0ac1

tomholub requested a review from seisvelas May 7, 2021 12:43

tomholub requested review from tomholub and removed request for tomholub May 7, 2021 12:43

tomholub requested review from tomholub and removed request for seisvelas May 7, 2021 12:47

tomholub approved these changes May 7, 2021
View reviewed changes

tomholub merged commit 7a6f3c8 into masterMay 7, 2021

tomholub deleted the feature/issue-193-attachmentsList branch May 7, 2021 15:21

tomholub mentioned this pull request May 7, 2021
auto-format code on build? #311
Closed

tomholub mentioned this pull request Jun 5, 2021
call FES in background after startup #340
Closed

Uh oh!

Conversation

qsoftdevelopment commented Apr 28, 2021

Uh oh!

tomholub commented Apr 28, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kharchevskyi commented Apr 29, 2021

Uh oh!

tomholub commented Apr 30, 2021

Uh oh!

tomholub commented Apr 30, 2021

Uh oh!

Kharchevskyi commented Apr 30, 2021

Uh oh!

tomholub commented Apr 30, 2021

Uh oh!

Kharchevskyi commented May 2, 2021

Uh oh!

tomholub commented May 3, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kharchevskyi commented May 5, 2021

Uh oh!

tomholub commented May 5, 2021

Uh oh!

Kharchevskyi commented May 5, 2021

Uh oh!

tomholub commented May 5, 2021

Uh oh!

tomholub commented May 5, 2021

Uh oh!

ghost commented May 7, 2021

Uh oh!

tomholub commented May 7, 2021

Uh oh!

KharchevskyiMay 7, 2021

Choose a reason for hiding this comment

Uh oh!

KharchevskyiMay 7, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomholubMay 7, 2021

Choose a reason for hiding this comment

Uh oh!

KharchevskyiMay 7, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KharchevskyiMay 7, 2021

Choose a reason for hiding this comment

Uh oh!

tomholubMay 7, 2021

Choose a reason for hiding this comment

Uh oh!

KharchevskyiMay 7, 2021

Choose a reason for hiding this comment

Uh oh!

Kharchevskyi commented May 7, 2021

Uh oh!

qsoftdevelopment commented May 7, 2021

Uh oh!

tomholub commented May 7, 2021

Uh oh!

tomholub left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

tomholub commented May 3, 2021•
edited
Loading

KharchevskyiMay 7, 2021•
edited
Loading

KharchevskyiMay 7, 2021•
edited
Loading