Skip to content

Feature/issue 314 costructing wkd urls - #318

Merged
tomholub merged 4 commits into
masterfrom
feature/issue-314-costructing-wkd-urls
May 17, 2021
Merged

Feature/issue 314 costructing wkd urls#318
tomholub merged 4 commits into
masterfrom
feature/issue-314-costructing-wkd-urls

Conversation

@ekievsky

@ekievskyekievsky commented May 17, 2021•
edited by tomholub
Loading

Copy link
Copy Markdown
Contributor

ZBase32 encoding implemented using open source solutions.
WKD URL construction was made based on Python implementation.

// edit tom: close#314

tomholub
tomholub requested changes May 17, 2021
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments below. Thanks!

Comment threadFlowCryptCommon/Extensions/Data/DataExntensions+ZBase32Encoding.swift
Comment threadFlowCryptTests/Functionallity/WKDURLs/WKDURLsConstructorTests.swift Outdated
Comment threadFlowCryptTests/Functionallity/WKDURLs/WKDURLsConstructorTests.swift
Comment threadFlowCryptTests/Functionallity/WKDURLs/WKDURLsConstructorTests.swift Outdated
tomholub
tomholub reviewed May 17, 2021
View reviewed changes
Comment threadFlowCrypt/Functionality/WKDURLs/WKDURLsCreator.swift Outdated
@ekievsky

ekievsky commented May 17, 2021

Copy link
Copy Markdown
ContributorAuthor

@tomholub may I have an access to SemaphoreCI? There is a build is failing.

@tomholub

tomholub commented May 17, 2021

Copy link
Copy Markdown
Collaborator

I've added you - please try again.

tomholub
tomholub approved these changes May 17, 2021
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good, one nitpick and it looks ready to merge.

Comment threadFlowCryptTests/Functionallity/WKDURLs/ZBase32EncodingTests.swift
)
}

func testEncryptedStringEncoding() throws {

@tomholubtomholubMay 17, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sha1 doesn't encrypt the data, it hashes it. So this would be testHashedStringEncoding

@tomholubtomholub mentioned this pull request May 17, 2021
Closed
@tomholub
tomholub merged commit 61eedbf into masterMay 17, 2021
@tomholub
tomholub deleted the feature/issue-314-costructing-wkd-urls branch May 17, 2021 21:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomholubtomholubtomholub approved these changes
@KharchevskyiKharchevskyiAwaiting requested review from Kharchevskyi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

constructing WKD urls

2 participants

@ekievsky@tomholub