Skip to content

Integrate WKD search - #338

Merged
tomholub merged 1 commit into
masterfrom
feature/issue-296-integrate-pub-lookup
Jun 5, 2021
Merged

Integrate WKD search#338
tomholub merged 1 commit into
masterfrom
feature/issue-296-integrate-pub-lookup

Conversation

@ekievsky

@ekievskyekievsky commented Jun 5, 2021

Copy link
Copy Markdown
Contributor

This PR integrates PubLookup instead of RemoteContactsProvider

close#296


Tests :

  • Difficult to test. We need to add separate layer of Networking to be able to inject it into appropriate classes and "spy" it.

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It troubles me that we can't easily test this, particularly relies on #307

@tomholub
tomholub enabled auto-merge (squash) June 5, 2021 14:12
@tomholub
tomholub merged commit 27eaf84 into masterJun 5, 2021
@tomholub
tomholub deleted the feature/issue-296-integrate-pub-lookup branch June 5, 2021 14:14
@tomholubtomholub changed the title PubLookup integrationIntegrate WKD searchJul 27, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

integrate WKD public key search

2 participants

@ekievsky@tomholub