Uh oh!
There was an error while loading. Please reload this page.
Check FES when loading inbox - #349
Merged
Merged
Conversation
ekievsky
commented
Jun 9, 2021
ContributorAuthor
@tomholub it is checking the user's FES after startup of logged in user and shows the toast. Should we keep this flow for both cases? |
tomholub
commented
Jun 9, 2021
via email
Collaborator
which two cases? …On Wednesday, June 9, 2021, Evgenii Kievsky ***@***.***> wrote:
@tomholub <https://github.com/tomholub> it is checking the user's FES
after startup of logged in user and shows the toast. Should we keep this
flow for both cases?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#349 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQDZEIYQGYVRHQ7AZX2FXDTR4I4PANCNFSM46LNXS7Q>
.
-- --
Tom James Holub <http://holub.me/> |
ekievsky
commented
Jun 9, 2021
ContributorAuthor
issue #339 is for checking FES on auth and issue #340 to check that on start up for logged in user. So this PR checks FES on Inbox screen and covers these 2 cases. It shows a toast message that says FES at $url not supported on iOS yet if there is |
tomholub
commented
Jun 9, 2021
via email
Collaborator
ok - that will do. will review in the evening. thanks! …On Wednesday, June 9, 2021, Evgenii Kievsky ***@***.***> wrote:
issue #339 <#339> is for
checking FES on auth and issue #340
<#340> to check that on
start up for logged in user. So this PR checks FES on Inbox screen and
covers these 2 cases. It shows a toast message that says FES at $url not
supported on iOS yet if there is service key which equals
enterprise-server for both cases
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#349 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQDZEI4F2E5CESER2DGCJDTR4VSNANCNFSM46LNXS7Q>
.
-- --
Tom James Holub <http://holub.me/> |
ekievsky
commented
Jun 9, 2021
ContributorAuthor
no rush, thank you! |
tomholub
reviewed
Jun 9, 2021
| private func checkFES() { | ||
| enterpriseServerApi.getActiveFesUrlForCurrentUser() | ||
| .then(on: .main) { [weak self] email in |
Collaborator
There was a problem hiding this comment.
this is an URL, right? not an email
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements checking FES on auth
close#339
Tests:
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):