Uh oh!
There was an error while loading. Please reload this page.
Cleanup user session on app start - #353
Merged
Merged
Conversation
Kharchevskyi
marked this pull request as ready for review
June 17, 2021 08:40
tomholub
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good, will re-test
Kharchevskyi
commented
Jun 17, 2021
ContributorAuthor
is it possible to prioritise #323 before merging this PR? |
tomholub
commented
Jun 18, 2021
Collaborator
Yes - definitely |
tomholub
commented
Jun 19, 2021
Collaborator
Please ping me once it has been brought up to date / conflicts resolved. Thanks! |
Kharchevskyi
commented
Jun 19, 2021
ContributorAuthor
Merged master. I haven't test all flows if it works with "new setup flow", but I assume it will. |
tomholub
approved these changes
Jun 21, 2021
tomholub
left a comment
Collaborator
There was a problem hiding this comment.
code ok still, will check functionality now
Collaborator
There was a problem hiding this comment.
Should rename isAnyKey to doesAnyKeyExist - filing another issue
tomholub
commented
Jun 21, 2021
Collaborator
works well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Fix issue in case user hasn't finish setup and kill the app
close#351
Tests:
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):