Uh oh!
There was an error while loading. Please reload this page.
Use Combine for MessageGateway - #400
Merged
Merged
Conversation
tomholub
commented
Jul 21, 2021
Collaborator
Thank you - is this fully functional for me to be able to merge this work into master and potentially later make a release in this state? |
Kharchevskyi
commented
Jul 21, 2021
ContributorAuthor
You can check as well, but as far as I tested, message was sent successfully, in both cases, when we compose a message and after creating a new backup |
tomholub
approved these changes
Jul 21, 2021
tomholub
left a comment
Collaborator
There was a problem hiding this comment.
Code looks great, with a note below. I'll build and test it now.
Comment on lines
+266
to
+279
| messageSender | ||
| .sendMail(mime: encrypted.mimeEncoded) | ||
| .sink( | ||
| receiveCompletion: { [weak self] result in | ||
| guard let error = result.getError() else { | ||
| return | ||
| } | ||
| self?.showAlert(error: error, message: "compose_error".localized) | ||
| }, | ||
| receiveValue: { [weak self] in | ||
| self?.handleSuccessfullySentMessage() | ||
| }) | ||
| .store(in: &cancellable) |
Collaborator
There was a problem hiding this comment.
I'll file an issue to create a slightly different convention here for increased clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replace usage of Promises in
MessageGatewayissue #290
Tests(delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):