Skip to content

Increase succintness of Future handling in Combine - #423

Merged
tomholub merged 1 commit into
masterfrom
feature/issue-402-increase-combine-succitness
Jul 29, 2021
Merged

Increase succintness of Future handling in Combine#423
tomholub merged 1 commit into
masterfrom
feature/issue-402-increase-combine-succitness

Conversation

@Kharchevskyi

@KharchevskyiKharchevskyi commented Jul 29, 2021•
edited by tomholub
Loading

Copy link
Copy Markdown
Contributor

This PR adds sinkFuture as an extension to Publisher

close#402

Tests(delete all except exactly one):

  • Not worth testing

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

Kharchevskyi
Kharchevskyi commented Jul 29, 2021
View reviewed changes

@KharchevskyiKharchevskyi left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tomholub
tomholub approved these changes Jul 29, 2021
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@tomholub
tomholub merged commit 38b982c into masterJul 29, 2021
@tomholub
tomholub deleted the feature/issue-402-increase-combine-succitness branch July 29, 2021 19:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomholubtomholubtomholub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

increase succintness of Future handling

2 participants

@Kharchevskyi@tomholub