Skip to content

Passphrase setup for EKM keys - #434

Merged
tomholub merged 8 commits into
masterfrom
feature/issue-279-passphrase-setup-ekm
Aug 15, 2021
Merged

Passphrase setup for EKM keys#434
tomholub merged 8 commits into
masterfrom
feature/issue-279-passphrase-setup-ekm

Conversation

@ekievsky

Copy link
Copy Markdown
Contributor

This PR adds passphrase setup with ekmkes

close#279


Tests:

  • Tests will be added later

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

Comment threadFlowCrypt/Controllers/Setup/SetupCreatePassphraseViewController.swift Outdated
Comment threadFlowCrypt/Controllers/Setup/SetupCreatePassphraseViewController.swift Outdated
Comment threadFlowCrypt/Controllers/Setup/SetupCreatePassphraseViewController.swift Outdated
Comment threadFlowCrypt/Controllers/Setup/SetupInitialViewController.swift Outdated
Comment threadFlowCrypt/Controllers/Setup/SetupCreatePassphraseViewController.swift Outdated
Comment threadFlowCrypt/Controllers/Setup/SetupCreatePassphraseViewController.swift Outdated
Comment threadFlowCrypt/Controllers/Setup/SetupCreatePassphraseViewController.swift Outdated
@tomholub

Copy link
Copy Markdown
Collaborator

It's progressing well. For comments that you have addressed, please click "Resolve conversation" after you have pushed the appropriate commit, to make it clear which ones were addressed and which not.

Comment threadFlowCrypt/Controllers/Setup/SetupEKMKeyViewController.swift Outdated

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Code is clear and well structured. Functionality works now.

In the future, more careful studying of the issue definition and larger context will help you code with more confidence, and reduce my workload when reviewing.

Thank you.

@tomholub
tomholub merged commit 3158e25 into masterAug 15, 2021
@tomholub
tomholub deleted the feature/issue-279-passphrase-setup-ekm branch August 15, 2021 10:41
@tomholub

Copy link
Copy Markdown
Collaborator

To clarify, it still holds that in cases when the issue is not well defined, asking questions is way better then guessing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement EKM integration to load private keys during setup

3 participants

@ekievsky@tomholub@flowcrypt-machine-user