Uh oh!
There was an error while loading. Please reload this page.
Passphrase setup for EKM keys - #434
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Fixed PR comments;
…lowCrypt/flowcrypt-ios into feature/issue-279-passphrase-setup-ekm
tomholub
commented
Aug 13, 2021
It's progressing well. For comments that you have addressed, please click "Resolve conversation" after you have pushed the appropriate commit, to make it clear which ones were addressed and which not. |
Uh oh!
There was an error while loading. Please reload this page.
tomholub
left a comment
There was a problem hiding this comment.
All looks good. Code is clear and well structured. Functionality works now.
In the future, more careful studying of the issue definition and larger context will help you code with more confidence, and reduce my workload when reviewing.
Thank you.
tomholub
commented
Aug 15, 2021
To clarify, it still holds that in cases when the issue is not well defined, asking questions is way better then guessing. |
This PR adds passphrase setup with ekmkes
close#279
Tests:
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):