Skip to content

Handling of core.composeEmail errors - #581

Merged
tomholub merged 2 commits into
masterfrom
feature/issue-411-handling-composeEmail-errors
Oct 1, 2021
Merged

Handling of core.composeEmail errors#581
tomholub merged 2 commits into
masterfrom
feature/issue-411-handling-composeEmail-errors

Conversation

@ivan-ushakov

@ivan-ushakovivan-ushakov commented Sep 30, 2021•
edited by tomholub
Loading

Copy link
Copy Markdown
Contributor

close#411

Tests(delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ivan-ushakov

ivan-ushakov commented Sep 30, 2021

Copy link
Copy Markdown
ContributorAuthor

Maybe ComposeMessageError should be updated to provide more human readable error description.

@tomholubtomholub mentioned this pull request Sep 30, 2021
Closed
@tomholub
tomholub enabled auto-merge (squash) September 30, 2021 21:33
@tomholub
tomholub merged commit 540d922 into masterOct 1, 2021
@tomholub
tomholub deleted the feature/issue-411-handling-composeEmail-errors branch October 1, 2021 09:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomholubtomholubtomholub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

handling of core.composeEmail errors

2 participants

@ivan-ushakov@tomholub