Skip to content

Decrypt encrypted attachment - #582

Merged
tomholub merged 9 commits into
masterfrom
feature/issue-195-decrypt-attachment
Oct 3, 2021
Merged

Decrypt encrypted attachment#582
tomholub merged 9 commits into
masterfrom
feature/issue-195-decrypt-attachment

Conversation

@ekievsky

@ekievskyekievsky commented Sep 30, 2021•
edited by tomholub
Loading

Copy link
Copy Markdown
Contributor

This PR adds file decryption of email attachments

close#195

Tests:

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ekievsky

ekievsky commented Sep 30, 2021

Copy link
Copy Markdown
ContributorAuthor

@tomholub which task should I take next?

tomholub
tomholub reviewed Sep 30, 2021
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code comments - haven't tested yet.

Comment threadFlowCrypt/Core/Core.swift
Comment threadFlowCrypt/Functionality/Mail Provider/Message Provider/MessageService.swift Outdated
Comment threadFlowCryptCommon/Extensions/StringExtensions.swift Outdated
Comment threadFlowCryptCommon/Extensions/StringExtensions.swift Outdated
Comment threadFlowCrypt/Functionality/Mail Provider/Message Provider/MessageService.swift Outdated
tomholub
tomholub reviewed Oct 2, 2021
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. will test

@tomholubtomholub changed the title Decrypt attachment[code ok] Decrypt attachmentOct 2, 2021
@tomholubtomholub changed the title [code ok] Decrypt attachmentDecrypt encrypted attachmentOct 3, 2021
tomholub
tomholub approved these changes Oct 3, 2021
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, works very nicely

haven't tested error scenarios

@tomholub
tomholub enabled auto-merge (squash) October 3, 2021 08:04
@tomholub
tomholub merged commit b0862f9 into masterOct 3, 2021
@tomholub
tomholub deleted the feature/issue-195-decrypt-attachment branch October 3, 2021 08:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomholubtomholubtomholub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

decrypt encrypted attachments during download

2 participants

@ekievsky@tomholub