Skip to content

[code ok] Disallow attester organisational rule - #591

Merged
tomholub merged 1 commit into
masterfrom
feature/issue-299-disallow-attester-org-rule
Oct 3, 2021
Merged

[code ok] Disallow attester organisational rule#591
tomholub merged 1 commit into
masterfrom
feature/issue-299-disallow-attester-org-rule

Conversation

@ekievsky

@ekievskyekievsky commented Oct 2, 2021

Copy link
Copy Markdown
Contributor

This PR updates canLookupThisRecipientOnAttester OrgRule, ignores attester api depending on canLookupThisRecipientOnAttester

close#299


Tests:

  • Difficult to test

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

…pi depending on canLookupThisRecipientOnAttester;

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@tomholubtomholub changed the title Disallow attester organisational rule[code ok] Disallow attester organisational ruleOct 2, 2021
@tomholub
tomholub merged commit d000343 into masterOct 3, 2021
@tomholub
tomholub deleted the feature/issue-299-disallow-attester-org-rule branch October 3, 2021 07:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement disallow_attester_search_for_domains OrgRule

2 participants

@ekievsky@tomholub