Skip to content

Don't add .pgp to file list when attaching files on compose screen - #615

Merged
tomholub merged 2 commits into
masterfrom
bugfix/issue-538-dont-add-pgp-to-attchments-when-composing
Oct 5, 2021
Merged

Don't add .pgp to file list when attaching files on compose screen#615
tomholub merged 2 commits into
masterfrom
bugfix/issue-538-dont-add-pgp-to-attchments-when-composing

Conversation

@ekievsky

@ekievskyekievsky commented Oct 5, 2021•
edited by tomholub
Loading

Copy link
Copy Markdown
Contributor

This PR adds .pgp extension to attachments right before sending them

close#538

Tests :

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

tomholub
tomholub approved these changes Oct 5, 2021
View reviewed changes

@tomholubtomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@tomholub
tomholub enabled auto-merge (squash) October 5, 2021 20:30
@tomholub
tomholub merged commit cb7d898 into masterOct 5, 2021
@tomholub
tomholub deleted the bugfix/issue-538-dont-add-pgp-to-attchments-when-composing branch October 5, 2021 21:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomholubtomholubtomholub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

don't add .pgp to file list when attaching files on compose screen

3 participants

@ekievsky@tomholub@flowcrypt-machine-user