Skip to content

issue 500 626 - version 0.2.0 build 1 (iOS 15) - #642

Merged
tomholub merged 9 commits into
masterfrom
issue-500-626-ios15-version020
Oct 8, 2021
Merged

issue 500 626 - version 0.2.0 build 1 (iOS 15)#642
tomholub merged 9 commits into
masterfrom
issue-500-626-ios15-version020

Conversation

@tomholub

@tomholubtomholub commented Oct 7, 2021

Copy link
Copy Markdown
Collaborator

This PR is a release of 0.2.0 for penetration testing by customer.

close#500 - release
close#626 - ios 15


Tests(delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@tomholub

Copy link
Copy Markdown
CollaboratorAuthor

@sosnovsky I'm sorry to bump you from issue to issue these days. Could you please see if you could do something about the following? Happens when I try to archive on this branch (Enterprise Flowcrypt + Any iOS Device (arm64) + Archive)

image

@sosnovsky

Copy link
Copy Markdown
Collaborator

Yes, I'll check it now

@sosnovsky

Copy link
Copy Markdown
Collaborator

I fixed this issue by using Swift Package Manager for Google libs, here is PR #643
Archive and running on device work well for me, the only issue is simulator on M1 Mac - it currently builds app with errors. Will try to fix it too.

But another issue is Semaphore CI - it doesn't have Xcode 13 image and can't run apps which have deployment target 15.0, so all tests are failing there.

@tomholub

Copy link
Copy Markdown
CollaboratorAuthor

I fixed this issue by using Swift Package Manager for Google libs, here is PR #643 Archive and running on device work well for me, the only issue is simulator on M1 Mac - it currently builds app with errors. Will try to fix it too.

But another issue is Semaphore CI - it doesn't have Xcode 13 image and can't run apps which have deployment target 15.0, so all tests are failing there.

Understood - is this something that can be configured / updated on SemaphoreCI, or semaphoreci does not support Xcode 13 yet at all?

* use SPM for Google libs
* fix tests configs
@sosnovsky

Copy link
Copy Markdown
Collaborator

Currently Semaphore doesn't support Xcode 13, I just messaged their support about Xcode update.
Last year they added Xcode 12 in the beginning of October, so possibly Xcode 13 will be added soon too.

@sosnovsky

Copy link
Copy Markdown
Collaborator

Semaphore added new OS image macos-xcode13 this week, I updated config, let's see how it works.

@tomholub

Copy link
Copy Markdown
CollaboratorAuthor

Thank you - this is very helpful. I'll keep this branch as a draft until then. You've solved my problem for now. (although xcode is now struggling to load dependencies - seems to be getting stuck - will retry).

If you get any news from Semaphore about when they plan to add support, please note it here. Thanks!

@tomholub

Copy link
Copy Markdown
CollaboratorAuthor

Semaphore added new OS image macos-xcode13 this week, I updated config, let's see how it works.

ah 👍

@tomholub
tomholub marked this pull request as ready for review October 7, 2021 20:27
@tomholub
tomholub enabled auto-merge (squash) October 7, 2021 20:27
@tomholub
tomholub merged commit 7318ace into masterOct 8, 2021
@tomholub
tomholub deleted the issue-500-626-ios15-version020 branch October 8, 2021 09:27
murataka added a commit that referenced this pull request Oct 9, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

set minimum required iOS 15 release enterprise app under new dev account

3 participants

@tomholub@sosnovsky@flowcrypt-machine-user