Gmail conversation view by Kharchevskyi · Pull Request #657 · FlowCrypt/flowcrypt-ios

Kharchevskyi · 2021-10-10T19:02:00Z

This PR add conversation view for gmail

close#608
close#725

Tests :

Does not need tests (refactor only, docs or internal changes)
Difficult to test (explain why)
Not worth testing
Tests will be added later (issue #...)
Tests added or updated

Manual testing:
Imap/Gmail

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

addresses the issue it closes (if any)
code is readable and understandable
is accompanied with tests, or tests are not needed
is free of vulnerabilities
is documented clearly and usefully, or doesn't need documentation

…r rendering threads

Kharchevskyi · 2021-10-12T15:11:38Z

Inbox

tomholub · 2021-10-12T17:31:31Z

looks good so far

Kharchevskyi · 2021-10-12T19:08:39Z

Kharchevskyi · 2021-10-12T19:49:08Z

@tomholub is it ok to show snippet as a subtitle? or it's better to show subject for thread
Also in thread detail controller should I show message snippet for each message in thread? or sender and time would be enough?

tomholub · 2021-10-13T07:22:25Z

is it ok to show snippet as a subtitle? or it's better to show subject for thread

Subject is more appropriate. You can see yourself, half of the messages are encrypted - like that, user would never be able to find the conversation they are looking for.

Also in thread detail controller should I show message snippet for each message in thread? or sender and time would be enough?

Let's start with sender and time, then re-evaluate.

Kharchevskyi · 2021-10-13T11:02:41Z

Inbox

Thread details

…ure/issue-6080-gmail-conversation

Kharchevskyi · 2021-10-16T21:15:26Z

…ure/issue-6080-gmail-conversation

ivan-ushakov · 2021-11-04T07:33:34Z

For example, this file was removed from current master branch:

FlowCrypt/Controllers/MessageList Extension/MsgListViewConroller.swift

But in this branch it is used across several view controllers

ivan-ushakov · 2021-11-04T07:44:09Z

Now I see that it was typo fix in view controller's name:

flowcrypt-ios/FlowCrypt/Controllers/MessageList Extension/MsgListViewConroller.swift
flowcrypt-ios/FlowCrypt/Controllers/MessageList Extension/MsgListViewController.swift

Let me continue with merge

tomholub · 2021-11-04T08:03:16Z

I know this won't be easy - please see how far you can get.

ivan-ushakov · 2021-11-04T08:41:50Z

Do we need this in console? Looks like trace level to me:

"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[Core][KeyMethods] pass phrase matches for key: CD7F6CD5BB6B0001C33E1A730DC6E2AAF9533212"
"ℹ️[PassPhraseService] memory: saving passphrase for key CD7F6CD5BB6B0001C33E1A730DC6E2AAF9533212"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft true"

tomholub · 2021-11-04T09:01:33Z

Do we need this in console? Looks like trace level to me:

"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[Core][KeyMethods] pass phrase matches for key: CD7F6CD5BB6B0001C33E1A730DC6E2AAF9533212"
"ℹ️[PassPhraseService] memory: saving passphrase for key CD7F6CD5BB6B0001C33E1A730DC6E2AAF9533212"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft false"
"ℹ️[ComposeViewController] Draft. Should save draft check"
"ℹ️[ComposeViewController] Draft. Should save draft true"

Agree, the draft logs should be removed. Someone may add them back just for debugging a particular thing if they need to, but not useful to keep in genera.

tomholub

Looking good so far, dots below are just to highlight

tomholub · 2021-11-04T09:11:08Z

+ onCompletion(MessageAction.markAsRead(false), .init(message: self.input.objMessage))
+ navigationController?.popViewController(animated: true)
+ } catch {
+ showToast("Could not mark message as unread: \(error)")


maybe handleOpErr(operation: .markUnread) for consistency?

Better to ask @Kharchevskyi

He's not available for the next few days. Can file an issue for later.

ivan-ushakov · 2021-11-04T10:50:08Z

@tomholub
Test CheckEncryptedEmailAfterRestartApp.spec.ts failing because we use different text in alert:

but test expects:

[iPhone Simulator iOS 15.0 #0-2] 1) INBOX: user is able to see encrypted email with pass phrase after restart app
[iPhone Simulator iOS 15.0 #0-2] Error: element ("-ios class chain:**/XCUIElementTypeStaticText[`label == "Wrong pass phrase, please try again"`]") still not displayed after 15000ms

tomholub · 2021-11-04T11:15:57Z

If this was indeed a retry (we already tried pass phrase in the test once and it was wrong, and now we are retrying) than the test is correct, meaning the implementation should be adjusted to match the test.

ivan-ushakov · 2021-11-04T11:18:27Z

If this was indeed a retry (we already tried pass phrase in the test once and it was wrong, and now we are retrying) than the test is correct, meaning the implementation should be adjusted to match the test.

We don't have wrong_passphrase in JavaScript code, so we can not get .wrongPassphrase

export enum DecryptErrTypes {
keyMismatch = 'key_mismatch',
usePassword = 'use_password',
wrongPwd = 'wrong_password',
noMdc = 'no_mdc',
badMdc = 'bad_mdc',
needPassphrase = 'need_passphrase',
format = 'format',
other = 'other',
}

tomholub · 2021-11-04T12:44:59Z

If this was indeed a retry (we already tried pass phrase in the test once and it was wrong, and now we are retrying) than the test is correct, meaning the implementation should be adjusted to match the test.
We don't have wrong_passphrase in JavaScript code, so we can not get .wrongPassphrase
export enum DecryptErrTypes {
keyMismatch = 'key_mismatch',
usePassword = 'use_password',
wrongPwd = 'wrong_password',
noMdc = 'no_mdc',
badMdc = 'bad_mdc',
needPassphrase = 'need_passphrase',
format = 'format',
other = 'other',
}

See how the code behaves on master: handlePassPhraseEntry

privatefunc handlePassPhraseEntry(rawMimeData:Data, with passPhrase:String){showSpinner("loading_title".localized, isUserInteractionEnabled:true)Task{do{letmatched=tryawait serviceActor.checkAndPotentiallySaveEnteredPassPhrase(passPhrase)if matched {
processedMessage =tryawait serviceActor.decryptAndProcessMessage(mime: rawMimeData)handleReceivedMessage()}else{handleWrongPathPhrase(for: rawMimeData, with: passPhrase)}}catch{handleError(error)}}}

the code should work the same on this branch. The first dialog gets shown phrase the first time (originally based on .needPassPhrase - not shown above), and produces a pass phrase dialog. User enters pass phrase. That gets handled by the code above, which will check if the pass phrase is good and produce another dialog, which will be the "wrong pass phrase" dialog. And again until user cancels or good pass phrase is entered.

tomholub

Thanks! Still need to manually run this to confirm.

tomholub

Thank you Ivan for getting it up to master!

I'll merge it but there will still be some fixes to do after:

download percentage is not getting rendered anymore - I think
with a very long subject, the number of messages in thread gets hidden because it's at the end

Start working on Gmail threads
7693da2

Kharchevskyi mentioned this pull request Oct 10, 2021
support conversation view in inbox #608
Closed
7 tasks

Kharchevskyi added 2 commits October 10, 2021 22:31

Create factory method for InboxViewController
ab73e55

Implement Gmail thread provider. Change InboxVontroller to prepare fo…
38c47c5
…r rendering threads

Kharchevskyi added 2 commits October 12, 2021 18:16

Render threads in inbox
36b1191

Merge origin
a8eb0e0

Sort messages and threads. Adopt support for message operations
f89b50a

Start working on thread details list
bf4607b

Reuse HeaderNode for threads
e073c2a

tomholub mentioned this pull request Oct 14, 2021
run appium tests in SemaphoreCI (or elsewhere) #518
Closed

Kharchevskyi added 3 commits October 16, 2021 21:37

Merge branch 'master' of github.com:FlowCrypt/flowcrypt-ios into feat…
d7eb4cc
…ure/issue-6080-gmail-conversation

Some updates to ThreadViewController
95ed677

Add functionality to expand message
eefd07a

tomholub mentioned this pull request Oct 18, 2021
save drafts during compose or reply #690
Merged
5 tasks

Expand unread message
38e7fc5

Kharchevskyi mentioned this pull request Oct 19, 2021
Can't fetch mails - SWIFT TASK CONTINUATION MISUSE #703
Closed

Kharchevskyi added 4 commits October 19, 2021 18:23

Merge branch 'master' of github.com:FlowCrypt/flowcrypt-ios into feat…
55a13ac
…ure/issue-6080-gmail-conversation

Minor update
35cbdef

Merge origin. Rewrite to async await
bf1eeb0

Uncomit search functionality
fd630a6

Kharchevskyi mentioned this pull request Oct 21, 2021
MessageOperationsProvider move to async await #725
Closed

Kharchevskyi added 2 commits October 21, 2021 22:32

Work on message operations with threads
991e53d

Move MessageOperationsProvider to async await
11d0959

Merge branch 'master' into feature/issue-6080-gmail-conversation
040bc41

tomholub mentioned this pull request Nov 4, 2021
IMAP/SMTP retry & logging + Gmail API (retry?) & logging #907
Open

After merge fixes
cde1350