Uh oh!
There was an error while loading. Please reload this page.
Feature/issue 695 upload progress - #773
Merged
Merged
Conversation
# Conflicts: # FlowCrypt/Controllers/Compose/ComposeViewController.swift
tomholub
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good 👍 will test
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| extension GmailService: MessageGateway { | ||
| func sendMail(input: MessageGatewayInput) async throws { | ||
| func sendMail(input: MessageGatewayInput, progressHandler: ((Float) -> Void)?) async throws { |
Contributor
There was a problem hiding this comment.
Maybe it will be easy to have one shared instance of GmailService and set progressHandler directly without setting it via sendMail?
CollaboratorAuthor
There was a problem hiding this comment.
Yes, it can be a possible solution, but as for me - having progressHandler along with sendMail makes it easier to follow mail sending flow.
Collaborator
There was a problem hiding this comment.
Agree with Roma here, passing it together in sendMail makes it more obvious how it's used and why.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds progress bar for emails sending process.
close#695
Tests(delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):