Uh oh!
There was an error while loading. Please reload this page.
PR review feedback for threads - #927
Merged
Merged
Conversation
ivan-ushakov
commented
Nov 5, 2021
ContributorAuthor
@Kharchevskyi |
ivan-ushakov
commented
Nov 5, 2021
ContributorAuthor
tomholub
reviewed
Nov 5, 2021
tomholub
left a comment
Collaborator
There was a problem hiding this comment.
looks good - see comment
Uh oh!
There was an error while loading. Please reload this page.
tomholub
commented
Nov 5, 2021
Collaborator
But indeed the layout is somewhat broken. Anton is off work until next week. Maybe @sosnovsky or @ekievsky can help. |
sosnovsky
commented
Nov 5, 2021
Collaborator
I'm here, should I try to fix these layout issues? |
ivan-ushakov
requested review from
sosnovsky
and removed request for
KharchevskyiNovember 5, 2021 10:44
ivan-ushakov
commented
Nov 5, 2021
ContributorAuthor
Please wait for my fix and do a review |
sosnovsky
approved these changes
Nov 5, 2021
sosnovsky
commented
Nov 5, 2021
Collaborator
Looks good now 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


close#920
Tests(delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):